[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-4.1 0/2] backup: Copy only dirty areas
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 for-4.1 0/2] backup: Copy only dirty areas |
|
Date: |
Mon, 5 Aug 2019 17:36:14 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 01.08.19 19:38, Max Reitz wrote:
> Hi,
>
> In a discussion with Vladimir today, we noticed that the backup job
> currently is pretty broken when using copy offloading. I don’t know
> about you, but my local filesystem (XFS) supports copy offloading, so
> the job uses it automatically. That means, that backup is broken and
> has been broken for a year on my local FS.
>
> The last working version was 2.12, so this isn’t a regression in 4.1.
> We could thus justify moving it to 4.2. But I think this should really
> go into 4.1, because this is not really an edge case and as far as I
> know users cannot do anything to prevent the backup job from performing
> copy offloading if the system and all involved block drivers support it.
> I just wonder why nobody has noticed...
Thanks for the review, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
signature.asc
Description: OpenPGP digital signature