[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr stru
From: |
Dmitry Fleytman |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures |
Date: |
Mon, 12 Aug 2019 11:21:04 +0300 |
Reviewed-by: Dmitry Fleytman <address@hidden>
> On 8 Aug 2019, at 17:34, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> This is a preparatory cleanup series.
>
> Commit 75020a70215 introduced 4 very equivalent structures:
> - tcp_header and tcp_hdr,
> - udp_header and udp_hdr.
>
> Choose the most widely use in the codebase, which happens to
> provide convenient bitfields manipulation macros and is not
> endian-specific.
>
> Philippe Mathieu-Daudé (6):
> hw/net/virtio-net: Use TCP_HEADER_FLAGS/TCP_HEADER_DATA_OFFSET macros
> net/colo-compare: Use the tcp_header structure
> net/filter-rewriter: Use the tcp_header structure
> hw/net/vmxnet3: Use the tcp_header structure
> net/eth: Remove the unused tcp_hdr structure
> net/eth: Remove the single use of udp_hdr structure
>
> hw/net/net_rx_pkt.c | 2 +-
> hw/net/net_tx_pkt.c | 9 +++++----
> hw/net/virtio-net.c | 9 ++-------
> include/net/eth.h | 47 ++++++++-----------------------------------
> net/colo-compare.c | 14 ++++++-------
> net/filter-rewriter.c | 37 +++++++++++++++++++---------------
> 6 files changed, 44 insertions(+), 74 deletions(-)
>
> --
> 2.20.1
>
- [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures, Philippe Mathieu-Daudé, 2019/08/08
- [Qemu-devel] [RFC PATCH 1/6] hw/net/virtio-net: Use TCP_HEADER_FLAGS/TCP_HEADER_DATA_OFFSET macros, Philippe Mathieu-Daudé, 2019/08/08
- [Qemu-devel] [RFC PATCH 2/6] net/colo-compare: Use the tcp_header structure, Philippe Mathieu-Daudé, 2019/08/08
- [Qemu-devel] [PATCH 3/6] net/filter-rewriter: Use the tcp_header structure, Philippe Mathieu-Daudé, 2019/08/08
- [Qemu-devel] [RFC PATCH 4/6] hw/net/vmxnet3: Use the tcp_header structure, Philippe Mathieu-Daudé, 2019/08/08
- [Qemu-devel] [PATCH 5/6] net/eth: Remove the unused tcp_hdr structure, Philippe Mathieu-Daudé, 2019/08/08
- [Qemu-devel] [PATCH 6/6] net/eth: Remove the single use of udp_hdr structure, Philippe Mathieu-Daudé, 2019/08/08
- Re: [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures,
Dmitry Fleytman <=
- Re: [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures, Philippe Mathieu-Daudé, 2019/08/18