Re: [Qemu-devel] [PATCH v4 11/29] typedefs: Separate incomplete types and function types

[Markus Armbruster]

Alex Bennée <address@hidden> writes:

> Markus Armbruster <address@hidden> writes:
>
>> While there, drop the obsolete file comment.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>> Tested-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>>  include/qemu/typedefs.h | 12 ++++++++----
>>  1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
>> index fcdaae58c4..29346648d4 100644
>> --- a/include/qemu/typedefs.h
>> +++ b/include/qemu/typedefs.h
>> @@ -1,10 +1,10 @@
>>  #ifndef QEMU_TYPEDEFS_H
>>  #define QEMU_TYPEDEFS_H
>>
>> -/* A load of opaque types so that device init declarations don't have to
>> -   pull in all the real definitions.  */
>> -
>> -/* Please keep this list in case-insensitive alphabetical order */
>> +/*
>> + * Incomplete struct types
>
> Maybe expand this a little...
>
>   "Incomplete struct types for modules that don't need the complete
>   definitions but still pass around typed variables."?

If we explain proper use of qemu/typedefs.h in HACKING, as discussed in
review of v1[*], we could point there.

> Otherwise:
>
> Reviewed-by: Alex Bennée <address@hidden>

Thanks!

>> + * Please keep this list in case-insensitive alphabetical order.
>> + */
>>  typedef struct AdapterInfo AdapterInfo;
>>  typedef struct AddressSpace AddressSpace;
>>  typedef struct AioContext AioContext;
>> @@ -101,6 +101,10 @@ typedef struct SHPCDevice SHPCDevice;
>>  typedef struct SSIBus SSIBus;
>>  typedef struct VirtIODevice VirtIODevice;
>>  typedef struct Visitor Visitor;
>> +
>> +/*
>> + * Function types
>> + */
>>  typedef void SaveStateHandler(QEMUFile *f, void *opaque);
>>  typedef int LoadStateHandler(QEMUFile *f, void *opaque, int version_id);
>
>
> --
> Alex Bennée