[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1] s390x/tcg: Fix VERIM with 32/64 bit elements
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v1] s390x/tcg: Fix VERIM with 32/64 bit elements |
Date: |
Wed, 14 Aug 2019 17:43:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 14.08.19 17:41, Cornelia Huck wrote:
> On Wed, 14 Aug 2019 17:12:42 +0200
> David Hildenbrand <address@hidden> wrote:
>
>> Wrong order of operands. The constant always comes last. Makes QEMU crash
>> reliably on specific git fetch invocations.
>>
>> Reported-by: Stefano Brivio <address@hidden>
>> Signed-off-by: David Hildenbrand <address@hidden>
>> ---
>>
>> I guess it is too late for 4.1 :(
>
> Yup :(
>
> But cc:stable worthy, I guess.
>
Yes. Added this bug to
https://wiki.qemu.org/Planning/4.1#Not_yet_fixed_in_any_rc
>>
>> ---
>> target/s390x/translate_vx.inc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/s390x/translate_vx.inc.c
>> b/target/s390x/translate_vx.inc.c
>> index 41d5cf869f..0caddb3958 100644
>> --- a/target/s390x/translate_vx.inc.c
>> +++ b/target/s390x/translate_vx.inc.c
>> @@ -213,7 +213,7 @@ static void get_vec_element_ptr_i64(TCGv_ptr ptr,
>> uint8_t reg, TCGv_i64 enr,
>> vec_full_reg_offset(v3), ptr, 16, 16, data, fn)
>> #define gen_gvec_3i(v1, v2, v3, c, gen) \
>> tcg_gen_gvec_3i(vec_full_reg_offset(v1), vec_full_reg_offset(v2), \
>> - vec_full_reg_offset(v3), c, 16, 16, gen)
>> + vec_full_reg_offset(v3), 16, 16, c, gen)
>> #define gen_gvec_4(v1, v2, v3, v4, gen) \
>> tcg_gen_gvec_4(vec_full_reg_offset(v1), vec_full_reg_offset(v2), \
>> vec_full_reg_offset(v3), vec_full_reg_offset(v4), \
>
--
Thanks,
David / dhildenb