[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] blockjob: drain all job nodes in block_job_d
|
From: |
Vladimir Sementsov-Ogievskiy |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] blockjob: drain all job nodes in block_job_drain |
|
Date: |
Fri, 16 Aug 2019 11:09:36 +0000 |
15.08.2019 16:15, Max Reitz wrote:
> On 02.08.19 11:52, Vladimir Sementsov-Ogievskiy wrote:
>> Instead of draining additional nodes in each job code, let's do it in
>> common block_job_drain, draining just all job's children.
>> BlockJobDriver.drain becomes unused, so, drop it at all.
>>
>> It's also a first step to finally get rid of blockjob->blk.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> ---
>
> What do you think of Kevin’s comment that draining the block nodes may
> actually be entirely unnecessary?
>
Hmmm, I'm afraid that nothing more than I can try, and if no real problems
with iotests I'll send a patch.
--
Best regards,
Vladimir