[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3 15/46] target/i386: introduce function ck
From: |
Jan Bobek |
Subject: |
Re: [Qemu-devel] [RFC PATCH v3 15/46] target/i386: introduce function ck_cpuid |
Date: |
Wed, 21 Aug 2019 01:07:25 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/15/19 11:01 AM, Aleksandar Markovic wrote:
>
> 15.08.2019. 04.23, "Jan Bobek" <address@hidden <mailto:address@hidden>> је
> написао/ла:
>>
>> Introduce a helper function to take care of instruction CPUID checks.
>>
>> Signed-off-by: Jan Bobek <address@hidden <mailto:address@hidden>>
>> ---
>
> Jan, what is the origin of "CK"? If it is a QEMU internal thing, perhaps use
> "CHECK".
>
> The function should be called check_cpuid(), imho. I know, Richard would like
> c_ci(), or simpler cc(), better.
It was completely my initiative to name it like that. I'll rename
it to check_cpuid().
-Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC PATCH v3 08/46] target/i386: make variable b1 const, (continued)
- [Qemu-devel] [RFC PATCH v3 08/46] target/i386: make variable b1 const, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 09/46] target/i386: make variable is_xmm const, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 10/46] target/i386: add vector register file alignment constraints, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 05/46] target/i386: use prefix from DisasContext, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 04/46] target/i386: use dflag from DisasContext, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 11/46] target/i386: introduce gen_(ld, st)d_env_A0, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 14/46] target/i386: introduce mnemonic aliases for several gvec operations, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 15/46] target/i386: introduce function ck_cpuid, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 06/46] target/i386: Simplify gen_exception arguments, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 07/46] target/i386: use pc_start from DisasContext, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 12/46] target/i386: introduce gen_sse_ng, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 13/46] target/i386: disable unused function warning temporarily, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 17/46] target/i386: introduce generic operand alias, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 16/46] target/i386: introduce instruction operand infrastructure, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 21/46] target/i386: introduce modrm operand, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 18/46] target/i386: introduce generic either-or operand, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 19/46] target/i386: introduce generic load-store operand, Jan Bobek, 2019/08/14
- [Qemu-devel] [RFC PATCH v3 20/46] target/i386: introduce tcg_temp operands, Jan Bobek, 2019/08/14