qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include


From: Laurent Vivier
Subject: Re: [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include
Date: Wed, 21 Aug 2019 11:07:05 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

Le 12/08/2019 à 13:37, Philippe Mathieu-Daudé a écrit :
> The "cpu.h" include makes devices target-specific. Since it
> is not used, remove it, so the device become generic (we can
> now compile it once for all targets).
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  hw/display/sm501.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 5918f59b2b..b15fb1ab00 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -28,7 +28,6 @@
>  #include "qapi/error.h"
>  #include "qemu/log.h"
>  #include "qemu/module.h"
> -#include "cpu.h"
>  #include "hw/hw.h"
>  #include "hw/char/serial.h"
>  #include "ui/console.h"
> 

Applied to my trivial-patches branch.
[fixed a conflict with  with 650d103d3ea9 ("Include hw/hw.h exactly
where needed")]

Thanks,
Laurent



reply via email to

[Prev in Thread] Current Thread [Next in Thread]