[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vq
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs |
Date: |
Thu, 22 Aug 2019 16:52:05 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Wed, Aug 21, 2019 at 09:07:25PM -0700, Raphael Norwitz wrote:
> On Fri, Jun 14, 2019 at 10:18:41AM +0100, Stefan Hajnoczi wrote:
> > On Tue, Jun 11, 2019 at 05:35:17PM -0700, Raphael Norwitz wrote:
> > > Of the 3 virtqueues, seabios only sets cmd, leaving ctrl
> > > and event without a physical address. This can cause
> > > vhost_verify_ring_part_mapping to return ENOMEM, causing
> > > the following logs:
> > >
> > > qemu-system-x86_64: Unable to map available ring for ring 0
> > > qemu-system-x86_64: Verify ring failure on region 0
> > >
> > > The qemu commit e6cc11d64fc998c11a4dfcde8fda3fc33a74d844
> > > has already resolved the issue for vhost scsi devices but
> > > the fix was never applied to vhost-user scsi devices.
> > >
> > > Signed-off-by: Raphael Norwitz <address@hidden>
> > > ---
> > > hw/scsi/vhost-user-scsi.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
>
> Ping on this. Any reason it has not been merged?
I think Paolo is away on vacation. I will send it through my tree
instead.
Stefan
signature.asc
Description: PGP signature