Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] vhost-user-blk: prevent using uninitialized vqs

[yuchenlin]

Raphael Norwitz <address@hidden> 於 2019-08-23 04:16 寫道： > > Same rational as: 
e6cc11d64fc998c11a4dfcde8fda3fc33a74d844 > > Of the 3 virtqueues, seabios only 
sets cmd, leaving ctrl > and event without a physical address. This can cause > 
vhost_verify_ring_part_mapping to return ENOMEM, causing > the following logs: 
> > qemu-system-x86_64: Unable to map available ring for ring 0 > 
qemu-system-x86_64: Verify ring failure on region 0 > > This has already been 
fixed for vhost scsi devices and was > recently vhost-user scsi devices. This 
commit fixes it for > vhost-user-blk devices. > > Suggested-by: Phillippe 
Mathieu-Daude <address@hidden> > Signed-off-by: Raphael Norwitz 
<address@hidden> Reviewed-by: yuchenlin <address@hidden> Thanks. > > > --- > 
hw/block/vhost-user-blk.c | 2 +- > 1 file changed, 1 insertion(+), 1 
deletion(-) > > diff --git a/hw/block/vhost-user-blk.c 
b/hw/block/vhost-user-blk.c > index 0b8c5df..63da9bb 100644 > --- 
a/hw/block/vhost-user-blk.c > +++ b/hw/block/vhost-user-blk.c > @@ -421,7 
+421,7 @@ static void vhost_user_blk_device_realize(DeviceState *dev, Error 
**errp) > } > > s->inflight = g_new0(struct vhost_inflight, 1); > - s->vqs = 
g_new(struct vhost_virtqueue, s->num_queues); > + s->vqs = g_new0(struct 
vhost_virtqueue, s->num_queues); > s->watch = 0; > s->connected = false; > > -- 
> 1.9.4 > >