Re: [Qemu-devel] [PATCH] modules-test: fix const cast

[Peter Maydell]

On Fri, 23 Aug 2019 at 10:06, Thomas Huth <address@hidden> wrote:
>
> On 8/22/19 7:42 PM, Paolo Bonzini wrote:
> > Signed-off-by: Paolo Bonzini <address@hidden>
> > ---
> >  tests/modules-test.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/modules-test.c b/tests/modules-test.c
> > index 3aef0e5..a8118e9 100644
> > --- a/tests/modules-test.c
> > +++ b/tests/modules-test.c
> > @@ -4,7 +4,7 @@
> >  static void test_modules_load(const void *data)
> >  {
> >      QTestState *qts;
> > -    const char **args = data;
> > +    const char **args = (const char **)data;
> >
> >      qts = qtest_init(NULL);
> >      qtest_module_load(qts, args[0], args[1]);
>
> Why did nobody notice this before? ... some additional words in the
> patch description would be fine.

It got into the tree because I don't have an --enable-modules
config in my set of things I run before merging. It's in
the Travis build set, but that only runs after the fact.

thanks
-- PMM