[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] configure: keep track of Python version
From: |
Cleber Rosa |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] configure: keep track of Python version |
Date: |
Fri, 23 Aug 2019 13:42:03 -0400 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Fri, Aug 23, 2019 at 02:44:15PM +0100, Peter Maydell wrote:
> On Fri, 23 Aug 2019 at 14:41, Cleber Rosa <address@hidden> wrote:
> > I see it being used by humans, so that brings a lot of subjetivity
> > into the matter. IMO this is not out of place within the build
> > system, given that a lot of requirements detected by configure will
> > print out their versions (GTK, nettle, spice, etc).
> >
> > But I'm certainly OK with dropping it if no value is perceived by
> > anyone else.
>
> I'd be happy with keeping it in the human-readable output
> that configure emits: if it's the wrong format there that's
> pretty harmless. But we shouldn't feed it into the makefiles
> unless we really need it, and we shouldn't let the format
> of whatever we do feed into the makefiles be driven by
> the desire to print something human-readable in configure's
> output -- there's no need for the two things to be the
> exact same string.
>
> thanks
> -- PMM
I couldn't agree more. The shortcut taken to print both the human
readable version and use that to check the version in the makefile was
unfortunate.
I'll send a fix proposal in a few.
Best,
- Cleber.