[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 17/20] cpu: TLB_FLAGS_MASK bit to force memor
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v9 17/20] cpu: TLB_FLAGS_MASK bit to force memory slow path |
Date: |
Fri, 23 Aug 2019 15:27:01 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/23/19 11:36 AM, Tony Nguyen wrote:
> The fast path is taken when TLB_FLAGS_MASK is all zero.
>
> TLB_FORCE_SLOW is simply a TLB_FLAGS_MASK bit to force the slow path,
> there are no other side effects.
>
> Signed-off-by: Tony Nguyen <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
> ---
> include/exec/cpu-all.h | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
FYI, while looking at this again, we do not need a new bit. You can simply set
TLB_MMIO for this use case, like we do for ROM.
This seems to be the only change to be made for this patch set; I can fix this
up myself while queuing.
r~
- [Qemu-devel] [PATCH v9 05/20] hw/intc/armv7m_nic: Access MemoryRegion with MemOp, (continued)
- [Qemu-devel] [PATCH v9 05/20] hw/intc/armv7m_nic: Access MemoryRegion with MemOp, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 06/20] hw/virtio: Access MemoryRegion with MemOp, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 07/20] hw/vfio: Access MemoryRegion with MemOp, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 08/20] exec: Access MemoryRegion with MemOp, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 10/20] memory: Access MemoryRegion with MemOp, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 09/20] cputlb: Access MemoryRegion with MemOp, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 12/20] target/mips: Hard code size with MO_{8|16|32|64}, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 11/20] hw/s390x: Hard code size with MO_{8|16|32|64}, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 13/20] exec: Hard code size with MO_{8|16|32|64}, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 17/20] cpu: TLB_FLAGS_MASK bit to force memory slow path, Tony Nguyen, 2019/08/23
- Re: [Qemu-devel] [PATCH v9 17/20] cpu: TLB_FLAGS_MASK bit to force memory slow path,
Richard Henderson <=
- [Qemu-devel] [PATCH v9 15/20] cputlb: Replace size and endian operands for MemOp, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 14/20] memory: Access MemoryRegion with endianness, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 16/20] memory: Single byte swap along the I/O path, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 18/20] cputlb: Byte swap memory transaction attribute, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 19/20] target/sparc: Add TLB entry with attributes, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 20/20] target/sparc: sun4u Invert Endian TTE bit, Tony Nguyen, 2019/08/23