Re: [Qemu-devel] [PATCH] qmp: Fix memory leak in migrate_params_test_apply

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH] qmp: Fix memory leak in migrate_params_test_apply

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
6e5df31 qmp: Fix memory leak in migrate_params_test_apply

=== OUTPUT BEGIN ===
ERROR: g_free(NULL) is safe this check is probably not required
#48: FILE: migration/migration.c:1254:
+        if (dest->tls_creds) {
+            g_free(dest->tls_creds);

ERROR: g_free(NULL) is safe this check is probably not required
#56: FILE: migration/migration.c:1262:
+        if (dest->tls_hostname) {
+            g_free(dest->tls_hostname);

total: 2 errors, 0 warnings, 17 lines checked

Commit 6e5df312feff (qmp: Fix memory leak in migrate_params_test_apply) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden