[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface |
Date: |
Tue, 27 Aug 2019 02:37:16 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
4c35c4b hd-geo-test: Add tests for lchs override
94fe50a bootdevice: FW_CFG interface for LCHS values
feb142b bootdevice: Refactor get_boot_devices_list
d0d1b0a bootdevice: Gather LCHS from all relevant devices
47aaba7 scsi: Propagate unrealize() callback to scsi-hd
c15a6ef bootdevice: Add interface to gather LCHS
5ee6a57 block: Support providing LCHS from user
7058d32 block: Refactor macros - fix tabbing
=== OUTPUT BEGIN ===
1/8 Checking commit 7058d3229d71 (block: Refactor macros - fix tabbing)
ERROR: Macros with complex values should be enclosed in parenthesis
#55: FILE: include/hw/block/block.h:65:
+#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \
+ DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \
+ DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \
DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)
total: 1 errors, 0 warnings, 37 lines checked
Patch 1/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/8 Checking commit 5ee6a57a8e93 (block: Support providing LCHS from user)
3/8 Checking commit c15a6ef42266 (bootdevice: Add interface to gather LCHS)
4/8 Checking commit 47aaba7c960c (scsi: Propagate unrealize() callback to
scsi-hd)
5/8 Checking commit d0d1b0a500c3 (bootdevice: Gather LCHS from all relevant
devices)
6/8 Checking commit feb142b1966b (bootdevice: Refactor get_boot_devices_list)
7/8 Checking commit 94fe50a2c30f (bootdevice: FW_CFG interface for LCHS values)
8/8 Checking commit 4c35c4b69cae (hd-geo-test: Add tests for lchs override)
WARNING: Block comments use a leading /* on a separate line
#641: FILE: tests/hd-geo-test.c:996:
+ "skipping hd-geo/override/* tests");
total: 0 errors, 1 warnings, 609 lines checked
Patch 8/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface, Sam Eiderman, 2019/08/27
- [Qemu-devel] [PATCH v6 1/8] block: Refactor macros - fix tabbing, Sam Eiderman, 2019/08/27
- [Qemu-devel] [PATCH v6 2/8] block: Support providing LCHS from user, Sam Eiderman, 2019/08/27
- [Qemu-devel] [PATCH v6 3/8] bootdevice: Add interface to gather LCHS, Sam Eiderman, 2019/08/27
- [Qemu-devel] [PATCH v6 4/8] scsi: Propagate unrealize() callback to scsi-hd, Sam Eiderman, 2019/08/27
- [Qemu-devel] [PATCH v6 5/8] bootdevice: Gather LCHS from all relevant devices, Sam Eiderman, 2019/08/27
- [Qemu-devel] [PATCH v6 6/8] bootdevice: Refactor get_boot_devices_list, Sam Eiderman, 2019/08/27
- [Qemu-devel] [PATCH v6 7/8] bootdevice: FW_CFG interface for LCHS values, Sam Eiderman, 2019/08/27
- [Qemu-devel] [PATCH v6 8/8] hd-geo-test: Add tests for lchs override, Sam Eiderman, 2019/08/27
- Re: [Qemu-devel] [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface,
no-reply <=
- Re: [Qemu-devel] [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface, no-reply, 2019/08/27