qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/9] qapi: Schema language cleanups & doc improv


From: no-reply
Subject: Re: [Qemu-devel] [PATCH 0/9] qapi: Schema language cleanups & doc improvements
Date: Wed, 28 Aug 2019 14:42:25 -0700 (PDT)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/9] qapi: Schema language cleanups & doc 
improvements
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d27cc29 docs/devel/qapi-code-gen: Improve QAPI schema language doc
72397f6 docs/devel/qapi-code-gen: Rewrite introduction to schema
62b02fb docs/devel/qapi-code-gen: Rewrite compatibility considerations
97bf23f docs/devel/qapi-code-gen: Reorder sections for readability
dfd13e2 tests/qapi-schema: Consistently name string tests string-FOO
5e21c3b qapi: Outlaw control characters in strings
1cd34f8 docs/devel/qapi-code-gen: Minor specification fixes
ab6ab29 qapi: Drop support for boxed alternate for commands, events
29df3a5 qapi: Drop check_type()'s redundant parameter @allow_optional

=== OUTPUT BEGIN ===
1/9 Checking commit 29df3a54e53e (qapi: Drop check_type()'s redundant parameter 
@allow_optional)
2/9 Checking commit ab6ab29d80e0 (qapi: Drop support for boxed alternate for 
commands, events)
3/9 Checking commit 1cd34f8cbd0e (docs/devel/qapi-code-gen: Minor specification 
fixes)
4/9 Checking commit 5e21c3bbc6d3 (qapi: Outlaw control characters in strings)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#72: FILE: tests/qapi-schema/string-control.json:2:
+{ 'command': '⌦
────────────────────────────────────────────────────────────────────────
' }
               ^

total: 1 errors, 1 warnings, 20 lines checked

Patch 4/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/9 Checking commit dfd13e2b3dec (tests/qapi-schema: Consistently name string 
tests string-FOO)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

total: 0 errors, 1 warnings, 18 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/9 Checking commit 97bf23fd9a0d (docs/devel/qapi-code-gen: Reorder sections 
for readability)
7/9 Checking commit 62b02fb7a675 (docs/devel/qapi-code-gen: Rewrite 
compatibility considerations)
8/9 Checking commit 72397f6335d8 (docs/devel/qapi-code-gen: Rewrite 
introduction to schema)
9/9 Checking commit d27cc292826e (docs/devel/qapi-code-gen: Improve QAPI schema 
language doc)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]