Re: [Qemu-devel] [PATCH v3 0/4] iotests: use python logging

[John Snow]

Gentle ping. This should be fairly easy to review, I hope; the worst of
it is making sure that no tests remain that don't engage an entry point
in iotests.py anymore.

On 8/20/19 7:52 PM, John Snow wrote:
> This series uses python logging to enable output conditionally on
> iotests.log(). We unify an initialization call (which also enables
> debugging output for those tests with -d) and then make the switch
> inside of iotests.
> 
> It will help alleviate the need to create logged/unlogged versions
> of all the various helpers we have made.
> 
> V3:
>  - Rebased for 4.1+; now based on main branch.
> 
> V2:
>  - Added all of the other python tests I missed to use script_initialize
>  - Refactored the common setup as per Ehabkost's suggestion
>  - Added protocol arguments to common initialization,
>    but this isn't strictly required.
> 
> John Snow (4):
>   iotests: add script_initialize
>   iotest 258: use script_main
>   iotests: add protocol support to initialization info
>   iotests: use python logging for iotests.log()
> 
>  tests/qemu-iotests/030        |   4 +-
>  tests/qemu-iotests/149        |   3 +-
>  tests/qemu-iotests/194        |   3 +-
>  tests/qemu-iotests/202        |   3 +-
>  tests/qemu-iotests/203        |   3 +-
>  tests/qemu-iotests/206        |   2 +-
>  tests/qemu-iotests/207        |   4 +-
>  tests/qemu-iotests/208        |   2 +-
>  tests/qemu-iotests/209        |   2 +-
>  tests/qemu-iotests/210        |   4 +-
>  tests/qemu-iotests/211        |   4 +-
>  tests/qemu-iotests/212        |   4 +-
>  tests/qemu-iotests/213        |   4 +-
>  tests/qemu-iotests/216        |   3 +-
>  tests/qemu-iotests/218        |   2 +-
>  tests/qemu-iotests/219        |   2 +-
>  tests/qemu-iotests/222        |   5 +-
>  tests/qemu-iotests/224        |   3 +-
>  tests/qemu-iotests/228        |   3 +-
>  tests/qemu-iotests/234        |   3 +-
>  tests/qemu-iotests/235        |   4 +-
>  tests/qemu-iotests/236        |   2 +-
>  tests/qemu-iotests/237        |   2 +-
>  tests/qemu-iotests/238        |   2 +
>  tests/qemu-iotests/242        |   2 +-
>  tests/qemu-iotests/245        |   1 +
>  tests/qemu-iotests/245.out    |  24 ++++----
>  tests/qemu-iotests/246        |   2 +-
>  tests/qemu-iotests/248        |   2 +-
>  tests/qemu-iotests/254        |   2 +-
>  tests/qemu-iotests/255        |   2 +-
>  tests/qemu-iotests/256        |   2 +-
>  tests/qemu-iotests/258        |   8 +--
>  tests/qemu-iotests/262        |   3 +-
>  tests/qemu-iotests/iotests.py | 108 ++++++++++++++++++++++------------
>  35 files changed, 124 insertions(+), 105 deletions(-)
>