Re: [Qemu-devel] [PATCH v9 05/13] block: move block_copy from block/backup.c to separate file

[Vladimir Sementsov-Ogievskiy]

28.08.2019 19:16, Max Reitz wrote:
> On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote:
>> Split block_copy to separate file, to be cleanly shared with backup-top
>> filter driver in further commits.
>>
>> It's a clean movement, the only change is drop "static" from interface
>> functions.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> ---
>>   include/block/block-copy.h |  59 +++++++
>>   block/backup.c             | 313 +------------------------------------
>>   block/block-copy.c         | 307 ++++++++++++++++++++++++++++++++++++
>>   block/Makefile.objs        |   1 +
>>   block/trace-events         |   2 +
>>   5 files changed, 370 insertions(+), 312 deletions(-)
>>   create mode 100644 include/block/block-copy.h
>>   create mode 100644 block/block-copy.c
> 
> May change depending on changes to the preceding patches, but FWIW
> 
> Reviewed-by: Max Reitz <address@hidden>
> 

If you don't mind, I'll keep it until the patch doing simple nochange movement.

-- 
Best regards,
Vladimir