[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 1/3] target/ppc: Optimize emulation of vpkpx
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v6 1/3] target/ppc: Optimize emulation of vpkpx instruction |
Date: |
Thu, 29 Aug 2019 08:31:25 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/29/19 6:34 AM, Stefan Brankovic wrote:
> Then I run my performance tests and I got following results(test is calling
> vpkpx 100000 times):
>
> 1) Current helper implementation: ~ 157 ms
>
> 2) helper implementation you suggested: ~94 ms
>
> 3) tcg implementation: ~75 ms
I assume you tested in a loop. If you have just the one expansion, you'll not
see the penalty for the icache expansion. To show the other extreme, you'd
want to test as separate sequential invocations.
That said, I'd be more interested in a real test case that isn't just calling
one instruction over and over. Is there a real test case that shows vpkpx in
the top 25 of the profile? With more than 0.5% of runtime?
r~