[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qga: add command guest-get-devices for reportin
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] qga: add command guest-get-devices for reporting VirtIO devices |
Date: |
Thu, 29 Aug 2019 11:13:53 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/29/19 11:03 AM, Tomáš Golembiovský wrote:
> Add command for reporting devices on Windows guest. The intent is not so
> much to report the devices but more importantly the driver (and its
> version) that is assigned to the device.
>
> Signed-off-by: Tomáš Golembiovský <address@hidden>
> +++ b/qga/qapi-schema.json
> @@ -1242,3 +1242,35 @@
> ##
> { 'command': 'guest-get-osinfo',
> 'returns': 'GuestOSInfo' }
> +
> +##
> +# @GuestDeviceInfo:
> +#
> +# @vendor-id: vendor ID as hexadecimal string in uper case without 0x prefix
> +# @device-id: device ID as hexadecimal string in uper case without 0x prefix
s/uper/upper/ twice
Should these be ints instead of strings (yes, it means they would be
decimal over the wire, which is not the typical representation)?
> +# @driver-name: name of the associated driver
> +# @driver-date: driver release date in format MM/DD/YY
Why US-centric? Better would be something like ISO, YYYY-MM-DD
> +# @driver-version: driver version
> +#
> +# Since: 4.1.1
4.2. We don't tend to add features on stable backport branches (as this
missed 4.1.0, we're unlikely to add it for 4.1.1).
> +##
> +{ 'struct': 'GuestDeviceInfo',
> + 'data': {
> + 'vendor-id': 'str',
> + 'device-id': 'str',
> + 'driver-name': 'str',
> + 'driver-date': 'str',
> + 'driver-version': 'str'
> + } }
> +
> +##
> +# @guest-get-devices:
> +#
> +# Retrieve information about device drivers in Windows guest
> +#
> +# Returns: @GuestOSInfo
> +#
> +# Since: 4.1.1
again, 4.2
> +##
> +{ 'command': 'guest-get-devices',
> + 'returns': ['GuestDeviceInfo'] }
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature