[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 07/11] monitor: adding tb_stats hmp command
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v8 07/11] monitor: adding tb_stats hmp command |
Date: |
Fri, 30 Aug 2019 16:11:00 +0100 |
User-agent: |
mu4e 1.3.4; emacs 27.0.50 |
vandersonmr <address@hidden> writes:
> Adding tb_stats [start|pause|stop|filter] command to hmp.
> This allows controlling the collection of statistics.
> It is also possible to set the level of collection:
> all, jit, or exec.
>
> tb_stats filter allow to only collect statistics for the TB
> in the last_search list.
>
> The goal of this command is to allow the dynamic exploration
> of the TCG behavior and quality. Therefore, for now, a
> corresponding QMP command is not worthwhile.
>
> Acked-by: Dr. David Alan Gilbert <address@hidden>
> Signed-off-by: Vanderson M. do Rosario <address@hidden>
<snip>
> index 4203cc728c..dcb30eea8a 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1796,11 +1796,17 @@ static bool main_loop_should_exit(void)
>
> static void main_loop(void)
> {
> +#ifdef CONFIG_TCG
> uint64_t ti;
> +#endif
> while (!main_loop_should_exit()) {
> +#ifdef CONFIG_TCG
> ti = profile_getclock();
> +#endif
> main_loop_wait(false);
> +#ifdef CONFIG_TCG
> dev_time += profile_getclock() - ti;
> +#endif
Shouldn't this have been s/CONFIG_PROFILER/CONFIG_TCG/ in the last
patch? Otherwise we might have a broken build half way through.
TBH I'm not even sure what dev_time is meant to represent. As we spend
all our time in the main_loop until we quit is seems to be more a less
wall clock time.
> }
> }
--
Alex Bennée
- Re: [Qemu-devel] [PATCH v8 02/11] accel: collecting TB execution count, (continued)
[Qemu-devel] [PATCH v8 03/11] accel: collecting JIT statistics, vandersonmr, 2019/08/29
[Qemu-devel] [PATCH v8 04/11] accel: replacing part of CONFIG_PROFILER with TBStats, vandersonmr, 2019/08/29
[Qemu-devel] [PATCH v8 06/11] Adding -d tb_stats to control TBStatistics collection:, vandersonmr, 2019/08/29
[Qemu-devel] [PATCH v8 05/11] accel: adding TB_JIT_TIME and full replacing CONFIG_PROFILER, vandersonmr, 2019/08/29
[Qemu-devel] [PATCH v8 07/11] monitor: adding tb_stats hmp command, vandersonmr, 2019/08/29
- Re: [Qemu-devel] [PATCH v8 07/11] monitor: adding tb_stats hmp command,
Alex Bennée <=
[Qemu-devel] [PATCH v8 08/11] Adding tb_stats [start|pause|stop|filter] command to hmp., vandersonmr, 2019/08/29
[Qemu-devel] [PATCH v8 10/11] monitor: adding new info cfg command, vandersonmr, 2019/08/29
[Qemu-devel] [PATCH v8 11/11] linux-user: dumping hot TBs at the end of the execution, vandersonmr, 2019/08/29
[Qemu-devel] [PATCH v8 09/11] Adding info [tb-list|tb|coverset] commands to HMP., vandersonmr, 2019/08/29