[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Lockup with --accel tcg,thread=single
|
From: |
Paolo Bonzini |
|
Subject: |
Re: Lockup with --accel tcg,thread=single |
|
Date: |
Tue, 1 Oct 2019 11:16:42 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 01/10/19 10:42, Alex Bennée wrote:
>
> Paolo Bonzini <address@hidden> writes:
>
>> On 30/09/19 21:20, Alex Bennée wrote:
>>> Does seem to imply the vCPU CPUState is where the queue is. That's not
>>> to say there shouldn't be a single work queue for thread=single.
>>
>> Indeed it doesn't. I confused this with commit a8efa60633 ("cpus: run
>> work items for all vCPUs if single-threaded", 2018-11-27).
>>
>> Are you going to make a patch to have a single work queue, or should
>> I?
>
> What's the neatest way to do it? Are you thinking just special case
> queue_work_on_cpu to special case first_cpu when mttcg is not enabled?
Yes, I cannot think of anything better.
Paolo