Re: [PATCH v2 1/2] qapi: Add feature flags to commands in qapi introspection

[Peter Krempa]

On Tue, Oct 01, 2019 at 08:40:21 +0200, Markus Armbruster wrote:
> Peter Krempa <address@hidden> writes:
> 
> > Similarly to features for struct types introduce the feature flags also
> > for commands. This will allow notifying management layers of fixes and
> > compatible changes in the behaviour of a command which may not be
> > detectable any other way.
> >
> > The changes were heavily inspired by commit 6a8c0b51025.
> >
> > Signed-off-by: Peter Krempa <address@hidden>
> 
> +1 on adding features to commands.
> 
> Patch conflicts with the technical debt payback work I posted before and
> after this series, although not nearly as badly as I expected.  It'll
> conflict some more with the parts I haven't flushed.  The funny bit: I
> went on that rampage in preparation of QAPI language extensions
> including "features everywhere, not just structs".
> 
> I'll look into how to best fit your work into mine.

Thanks. I have patches ready which depend on this to enable blockdev so
please let me know if the design changes somehow.