Re: [PATCH 5/6] block-stream: add compress option

[Eric Blake]

On 10/1/19 2:27 PM, Andrey Shinkevich wrote:
> Signed-off-by: Anton Nefedov <address@hidden>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> Signed-off-by: Andrey Shinkevich <address@hidden>
> ---

The commit summary says 'what', but left out a body stating 'why'. 
Reading the whole series makes it obvious, but landing on this commit in 
isolation during a future 'git bisect' less so.  It's not necessarily a 
show-stopper, but food for thought in writing future commit messages.


> +++ b/qapi/block-core.json
> @@ -2544,6 +2544,9 @@
>   #
>   # @speed:  the maximum speed, in bytes per second
>   #
> +# @compress: true to compress data, if the target format supports it.

Looking at neighbors, it would be more consistent to drop the trailing dot.

> +#            (default: false). Since 4.1.
> +#

4.2, now.

>   # @on-error: the action to take on an error (default report).
>   #            'stop' and 'enospc' can only be used if the block device
>   #            supports io-status (see BlockInfo).  Since 1.3.
> @@ -2576,7 +2579,7 @@
>   { 'command': 'block-stream',
>     'data': { '*job-id': 'str', 'device': 'str', '*base': 'str',
>               '*base-node': 'str', '*backing-file': 'str', '*speed': 'int',
> -            '*on-error': 'BlockdevOnError',
> +            '*compress': 'bool', '*on-error': 'BlockdevOnError',
>               '*auto-finalize': 'bool', '*auto-dismiss': 'bool' } }
>   
>   ##

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org