Re: [PATCH v2 0/6] qcow2: advanced compression options

[Vladimir Sementsov-Ogievskiy]

Hi,

02.10.2019 18:07, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
> 
> 
> 
> Hi,
> 
> This series failed the docker-quick@centos7 build test. Please find the 
> testing commands and
> their output below. If you have Docker installed, you can probably reproduce 
> it
> locally.
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> make docker-image-centos7 V=1 NETWORK=1
> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
> === TEST SCRIPT END ===
> 
>    CC      block/parallels.o
>    CC      block/blklogwrites.o
>    CC      block/block-backend.o
> /tmp/qemu-test/src/block/qcow2.c:4077:64: error: unknown type name 'AioTask'
>   static coroutine_fn int qcow2_co_pwritev_compressed_task_entry(AioTask 
> *task)
>                                                                  ^
> /tmp/qemu-test/src/block/qcow2.c: In function 
> 'qcow2_co_pwritev_compressed_part':
> /tmp/qemu-test/src/block/qcow2.c:4098:5: error: unknown type name 
> 'AioTaskPool'
>       AioTaskPool *aio = NULL;
>       ^


Who knows, what is wrong with it? Seems patchew ignores Based-on: tag in 
cover-letter,
which is written as "Based-on: https://github.com/XanClic/qemu.git block"...
These new types and functions are defined in Max's block branch.


> /tmp/qemu-test/src/block/qcow2.c:4123:5: error: implicit declaration of 
> function 'aio_task_pool_status' [-Werror=implicit-function-declaration]
>       while (bytes && aio_task_pool_status(aio) == 0) {
>       ^
> /tmp/qemu-test/src/block/qcow2.c:4123:5: error: nested extern declaration of 
> 'aio_task_pool_status' [-Werror=nested-externs]
> /tmp/qemu-test/src/block/qcow2.c:4130:13: error: implicit declaration of 
> function 'aio_task_pool_new' [-Werror=implicit-function-declaration]
>               aio = aio_task_pool_new(QCOW2_MAX_WORKERS);
>               ^
> /tmp/qemu-test/src/block/qcow2.c:4130:13: error: nested extern declaration of 
> 'aio_task_pool_new' [-Werror=nested-externs]
> /tmp/qemu-test/src/block/qcow2.c:4130:37: error: 'QCOW2_MAX_WORKERS' 
> undeclared (first use in this function)
>               aio = aio_task_pool_new(QCOW2_MAX_WORKERS);
>                                       ^
> /tmp/qemu-test/src/block/qcow2.c:4130:37: note: each undeclared identifier is 
> reported only once for each function it appears in
> /tmp/qemu-test/src/block/qcow2.c:4133:9: error: implicit declaration of 
> function 'qcow2_add_task' [-Werror=implicit-function-declaration]
>           ret = qcow2_add_task(bs, aio, 
> qcow2_co_pwritev_compressed_task_entry,
>           ^
> /tmp/qemu-test/src/block/qcow2.c:4133:9: error: nested extern declaration of 
> 'qcow2_add_task' [-Werror=nested-externs]
> /tmp/qemu-test/src/block/qcow2.c:4133:39: error: 
> 'qcow2_co_pwritev_compressed_task_entry' undeclared (first use in this 
> function)
>           ret = qcow2_add_task(bs, aio, 
> qcow2_co_pwritev_compressed_task_entry,
>                                         ^
> /tmp/qemu-test/src/block/qcow2.c:4145:9: error: implicit declaration of 
> function 'aio_task_pool_wait_all' [-Werror=implicit-function-declaration]
>           aio_task_pool_wait_all(aio);
>           ^
> /tmp/qemu-test/src/block/qcow2.c:4145:9: error: nested extern declaration of 
> 'aio_task_pool_wait_all' [-Werror=nested-externs]
> /tmp/qemu-test/src/block/qcow2.c: At top level:
> /tmp/qemu-test/src/block/qcow2.c:4012:1: error: 
> 'qcow2_co_pwritev_compressed_task' defined but not used 
> [-Werror=unused-function]
>   qcow2_co_pwritev_compressed_task(BlockDriverState *bs,
>   ^
> cc1: all warnings being treated as errors
> make: *** [block/qcow2.o] Error 1
> make: *** Waiting for unfinished jobs....
> Traceback (most recent call last):
>    File "./tests/docker/docker.py", line 662, in <module>
> ---
>      raise CalledProcessError(retcode, cmd)
> subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
> '--label', 'com.qemu.instance.uuid=4a0fa981cdb74b48946f62d3df956bf1', '-u', 
> '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
> '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', 
> '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
> '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
> '/var/tmp/patchew-tester-tmp-zk1t0pwl/src/docker-src.2019-10-02-11.05.34.28094:/var/tmp/qemu:z,ro',
>  'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit 
> status 2.
> filter=--filter=label=com.qemu.instance.uuid=4a0fa981cdb74b48946f62d3df956bf1
> make[1]: *** [docker-run] Error 1
> make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-zk1t0pwl/src'
> make: *** [docker-run-test-quick@centos7] Error 2
> 
> real    1m39.268s
> user    0m7.984s
> 
> 
> The full log is available at
> http://patchew.org/logs/address@hidden/testing.docker-quick@centos7/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to address@hidden
> 


-- 
Best regards,
Vladimir