Re: [PULL v2 0/8] Ide patches

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [PULL v2 0/8] Ide patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e107ed3 hd-geo-test: Add tests for lchs override
cd1188f bootdevice: FW_CFG interface for LCHS values
62792ad bootdevice: Refactor get_boot_devices_list
00d2bab bootdevice: Gather LCHS from all relevant devices
d85b0dc scsi: Propagate unrealize() callback to scsi-hd
02cd6f9 bootdevice: Add interface to gather LCHS
b06aff8 block: Support providing LCHS from user
335e38a block: Refactor macros - fix tabbing

=== OUTPUT BEGIN ===
1/8 Checking commit 335e38a12a6e (block: Refactor macros - fix tabbing)
ERROR: Macros with complex values should be enclosed in parenthesis
#57: FILE: include/hw/block/block.h:65:
+#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf)                      \
+    DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0),                  \
+    DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0),                \
     DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)

total: 1 errors, 0 warnings, 37 lines checked

Patch 1/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/8 Checking commit b06aff8ec8cb (block: Support providing LCHS from user)
3/8 Checking commit 02cd6f97ec31 (bootdevice: Add interface to gather LCHS)
4/8 Checking commit d85b0dccde73 (scsi: Propagate unrealize() callback to 
scsi-hd)
5/8 Checking commit 00d2bab4fc17 (bootdevice: Gather LCHS from all relevant 
devices)
6/8 Checking commit 62792ad95240 (bootdevice: Refactor get_boot_devices_list)
7/8 Checking commit cd1188f9546d (bootdevice: FW_CFG interface for LCHS values)
8/8 Checking commit e107ed371074 (hd-geo-test: Add tests for lchs override)
WARNING: Block comments use a leading /* on a separate line
#650: FILE: tests/hd-geo-test.c:1003:
+                       "skipping hd-geo/override/* tests");

total: 0 errors, 1 warnings, 616 lines checked

Patch 8/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden