[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/7] tests/fw_cfg: Run the tests on big-endian targets
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 7/7] tests/fw_cfg: Run the tests on big-endian targets |
Date: |
Fri, 4 Oct 2019 10:05:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
On 04/10/2019 00:54, Philippe Mathieu-Daudé wrote:
> We have been restricting our fw_cfg tests to the PC machine,
> which is a little-endian architecture.
> The fw_cfg device is also used on the SPARC and PowerPC
> architectures, which can run in big-endian configuration.
>
> Since we want to be sure our device does not regress
> regardless the endianess used, enable this test one
> these targets.
>
> The NUMA selector is X86 specific, restrict it to this arch.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/Makefile.include | 2 ++
> tests/fw_cfg-test.c | 18 +++++++++++++++---
> 2 files changed, 17 insertions(+), 3 deletions(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 3543451ed3..322bdb36ff 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -242,6 +242,7 @@ check-qtest-ppc64-$(CONFIG_VGA) +=
> tests/display-vga-test$(EXESUF)
> check-qtest-ppc64-y += tests/numa-test$(EXESUF)
> check-qtest-ppc64-$(CONFIG_IVSHMEM_DEVICE) += tests/ivshmem-test$(EXESUF)
> check-qtest-ppc64-y += tests/cpu-plug-test$(EXESUF)
> +check-qtest-ppc64-y += tests/fw_cfg-test$(EXESUF)
Perhaps only a detail, but ppc64 (pseries) doesn't use fw_cfg, but ppc
(mac99, g3beige and prep) does, so perhaps you should rather add the
test to check-qtest-ppc-y (and it will be inherited by ppc64)?
Thanks,
Laurent
- Re: [PATCH 2/7] tests/libqos/fw_cfg: Document mm_fw_cfg_init to drop mm_fw_cfg_uninit, (continued)
- [PATCH 3/7] tests/libqos/fw_cfg: Document pc_fw_cfg_init to drop pc_fw_cfg_uninit, Philippe Mathieu-Daudé, 2019/10/03
- [PATCH 4/7] tests/fw_cfg: Let the tests use a context, Philippe Mathieu-Daudé, 2019/10/03
- [PATCH 5/7] tests/libqos/fw_cfg: Pass QTestState as argument, Philippe Mathieu-Daudé, 2019/10/03
- [PATCH 6/7] tests/fw_cfg: Declare one QFWCFG for all tests, Philippe Mathieu-Daudé, 2019/10/03
- [PATCH 7/7] tests/fw_cfg: Run the tests on big-endian targets, Philippe Mathieu-Daudé, 2019/10/03
- Re: [PATCH 7/7] tests/fw_cfg: Run the tests on big-endian targets,
Laurent Vivier <=
- Re: [PATCH 7/7] tests/fw_cfg: Run the tests on big-endian targets, Philippe Mathieu-Daudé, 2019/10/04
- Re: [PATCH 7/7] tests/fw_cfg: Run the tests on big-endian targets, Laurent Vivier, 2019/10/04
- Re: [PATCH 7/7] tests/fw_cfg: Run the tests on big-endian targets, Philippe Mathieu-Daudé, 2019/10/04
- Re: [PATCH 7/7] tests/fw_cfg: Run the tests on big-endian targets, Laurent Vivier, 2019/10/04
- Re: [PATCH 7/7] tests/fw_cfg: Run the tests on big-endian targets, Philippe Mathieu-Daudé, 2019/10/04
- Re: [PATCH 7/7] tests/fw_cfg: Run the tests on big-endian targets, Thomas Huth, 2019/10/07
Re: [PATCH 0/7] fw_cfg: Run tests on big-endian, no-reply, 2019/10/03