Re: [PATCH v6 02/10] hw/i386/pc: rename functions shared with non-PC machines

[Stefano Garzarella]

On Fri, Oct 04, 2019 at 11:37:44AM +0200, Sergio Lopez wrote:
> The following functions are named *pc* but are not PC-machine specific
> but generic to the X86 architecture, rename them:
> 
>   load_linux                 -> x86_load_linux
>   pc_new_cpu                 -> x86_new_cpu
>   pc_cpus_init               -> x86_cpus_init
>   pc_cpu_index_to_props      -> x86_cpu_index_to_props
>   pc_get_default_cpu_node_id -> x86_get_default_cpu_node_id
>   pc_possible_cpu_arch_ids   -> x86_possible_cpu_arch_ids
>   old_pc_system_rom_init     -> x86_system_rom_init
> 
> Signed-off-by: Sergio Lopez <address@hidden>
> ---
>  include/hw/i386/pc.h |  2 +-
>  hw/i386/pc.c         | 28 ++++++++++++++--------------
>  hw/i386/pc_piix.c    |  2 +-
>  hw/i386/pc_q35.c     |  2 +-
>  hw/i386/pc_sysfw.c   |  6 +++---
>  5 files changed, 20 insertions(+), 20 deletions(-)
> 

LGTM!

Reviewed-by: Stefano Garzarella <address@hidden>

Thanks,
Stefano