[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 12/30] Makefile: Remove generated files when doing 'distclean'
From: |
Aleksandar Markovic |
Subject: |
Re: [PULL 12/30] Makefile: Remove generated files when doing 'distclean' |
Date: |
Mon, 7 Oct 2019 09:13:13 +0200 |
On Monday, October 7, 2019, Thomas Huth <address@hidden> wrote:
----- Original Message -----
> From: "Paolo Bonzini" <address@hidden>
> To: "Peter Maydell" <address@hidden>
> Cc: "QEMU Developers" <address@hidden>, "Thomas Huth" <address@hidden>
> Sent: Friday, October 4, 2019 6:48:47 PM
> Subject: Re: [PULL 12/30] Makefile: Remove generated files when doing 'distclean'
>
> On 04/10/19 14:20, Peter Maydell wrote:
> > On Wed, 2 Oct 2019 at 18:07, Paolo Bonzini <address@hidden> wrote:
> >>
> >> From: Thomas Huth <address@hidden>
> >>
> >> When running "make distclean" we currently leave a lot of generated
> >> files in the build directory. Fix that.
> >>
> >> Signed-off-by: Thomas Huth <address@hidden>
> >> Reviewed-by: John Snow <address@hidden>
> >> Signed-off-by: Paolo Bonzini <address@hidden>
> >> ---
> >
> >> diff --git a/tests/Makefile.include b/tests/Makefile.include
> >> index 3543451..48b52da 100644
> >> --- a/tests/Makefile.include
> >> +++ b/tests/Makefile.include
> >> @@ -1176,11 +1176,21 @@ check: check-block check-qapi-schema check-unit
> >> check-softfloat check-qtest chec
> >> check-clean:
> >> rm -rf $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y)
> >> rm -rf $(sort $(foreach target,$(SYSEMU_TARGET_LIST),
> >> $(check-qtest-$(target)-y)) $(check-qtest-generic-y))
> >> - rm -f tests/test-qapi-gen-timestamp
> >> rm -rf $(TESTS_VENV_DIR) $(TESTS_RESULTS_DIR)
> >> + rm -f tests/qemu-iotests/common.env tests/qemu-iotests/check.*
> >> + rm -f tests/test-qapi-gen-timestamp tests/qht-bench$(EXESUF) \
> >> + tests/fp/fp-test tests/fp/*.out tests/qapi-schema/*.test.*
> >>
> >> clean: check-clean
> >
> > Hi; this change breaks the sequence
> > 'make clean; make; make check'
> >
> > because now 'make clean' removes tests/qemu-iotests/common.env.
> > But this file is created by 'configure', not by 'make', so if there's
> > no other reason why 'make' needs to re-run configure then we get
> > to the 'make check' stage with the file not existing, and then
> > when we try to run the iotests they fail with:
> >
> > ./check: line 60:
> > /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/common.env:
> > No such file or directory
> > check: failed to source common.env (make sure the qemu-iotests are run
> > from tests/qemu-iotests in the build tree)
> > /home/petmay01/linaro/qemu-for-merges/tests/Makefile.include:1102:
> > recipe for target 'check-tests/check-block.sh' failed
>
> I've dropped this patch and will send v3 that adds back the VMX patches.
Thanks, and I will rework the patch to only remove that file during "make distclean",
and not already during "make clean".
Thomas
The commit message says that it affects "make distclean". It does not mention "make clean", while the change obviously affects "make clean" too. It looks to me that the commit message was misleading. It would be good if the new version of the patch has clearer (not misleading) commit message, specifying what exactly is affected by the change. Or, alteratively, this patch could be split into several ones.
Thanks,
Aleksandar
- [PULL 08/30] target/i386: work around KVM_GET_MSRS bug for secondary execution controls, (continued)
- [PULL 08/30] target/i386: work around KVM_GET_MSRS bug for secondary execution controls, Paolo Bonzini, 2019/10/02
- [PULL 05/30] target/i386: add VMX definitions, Paolo Bonzini, 2019/10/02
- [PULL 10/30] qemu-pr-helper: fix crash in mpath_reconstruct_sense, Paolo Bonzini, 2019/10/02
- [PULL 11/30] replay: don't synchronize memory operations in replay mode, Paolo Bonzini, 2019/10/02
- [PULL 07/30] target/i386: add VMX features, Paolo Bonzini, 2019/10/02
- [PULL 09/30] target/i386/kvm: Silence warning from Valgrind about uninitialized bytes, Paolo Bonzini, 2019/10/02
- [PULL 12/30] Makefile: Remove generated files when doing 'distclean', Paolo Bonzini, 2019/10/02
[PULL 13/30] hw/isa: Introduce a CONFIG_ISA_SUPERIO switch for isa-superio.c, Paolo Bonzini, 2019/10/02
[PULL 14/30] ide: fix leak from qemu_allocate_irqs, Paolo Bonzini, 2019/10/02
[PULL 16/30] mcf5208: fix leak from qemu_allocate_irqs, Paolo Bonzini, 2019/10/02
[PULL 15/30] microblaze: fix leak of fdevice tree blob, Paolo Bonzini, 2019/10/02
[PULL 17/30] hppa: fix leak from g_strdup_printf, Paolo Bonzini, 2019/10/02
[PULL 18/30] mips: fix memory leaks in board initialization, Paolo Bonzini, 2019/10/02
[PULL 20/30] lm32: do not leak memory on object_new/object_unref, Paolo Bonzini, 2019/10/02
[PULL 21/30] docker: test-debug: disable LeakSanitizer, Paolo Bonzini, 2019/10/02
[PULL 19/30] cris: do not leak struct cris_disasm_data, Paolo Bonzini, 2019/10/02
[PULL 22/30] i386: Add CPUID bit for CLZERO and XSAVEERPTR, Paolo Bonzini, 2019/10/02