[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 8/8] hw/misc/vmcoreinfo: Add comment about reset handler
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 8/8] hw/misc/vmcoreinfo: Add comment about reset handler |
Date: |
Tue, 8 Oct 2019 16:34:55 +0200 |
The VM coreinfo device does not sit on a bus, so it won't be
reset automatically. This is why it calls qemu_register_reset().
Add a comment about it, so we don't convert its reset handler
to a DeviceReset method.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/misc/vmcoreinfo.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/misc/vmcoreinfo.c b/hw/misc/vmcoreinfo.c
index 326a3ce8f4..a9d718fc23 100644
--- a/hw/misc/vmcoreinfo.c
+++ b/hw/misc/vmcoreinfo.c
@@ -61,6 +61,10 @@ static void vmcoreinfo_realize(DeviceState *dev, Error
**errp)
NULL, fw_cfg_vmci_write, s,
&s->vmcoreinfo, sizeof(s->vmcoreinfo), false);
+ /*
+ * This device requires to register a global reset because it is
+ * not plugged to a bus (which, as its QOM parent, would reset it).
+ */
qemu_register_reset(vmcoreinfo_reset, dev);
vmcoreinfo_state = s;
}
--
2.21.0
- Re: [PATCH v2 3/8] hw/ide/piix: Convert reset handler to DeviceReset, (continued)
- [PATCH v2 4/8] hw/ide/sii3112: Convert reset handler to DeviceReset, Philippe Mathieu-Daudé, 2019/10/08
- [PATCH v2 5/8] hw/ide/via82c: Convert reset handler to DeviceReset, Philippe Mathieu-Daudé, 2019/10/08
- [PATCH v2 6/8] hw/isa/vt82c686: Convert reset handler to DeviceReset, Philippe Mathieu-Daudé, 2019/10/08
- [PATCH v2 7/8] hw/input/lm832x: Convert reset handler to DeviceReset, Philippe Mathieu-Daudé, 2019/10/08
- [PATCH v2 8/8] hw/misc/vmcoreinfo: Add comment about reset handler,
Philippe Mathieu-Daudé <=
- Re: [PATCH v2 0/8] hw: Convert various reset() handler to DeviceReset, Li Qiang, 2019/10/09