[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 1/3] acpi: cpuhp: fix 'Command data' description is spec
From: |
Laszlo Ersek |
Subject: |
Re: [RFC 1/3] acpi: cpuhp: fix 'Command data' description is spec |
Date: |
Thu, 10 Oct 2019 14:33:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 10/09/19 15:22, Igor Mammedov wrote:
> QEMU returns 0, in case of erro or invalid value in 'Command field',
> make spec match reality, i.e.
Unfinished thought?
>
> Also fix returned value description in case 'Command field' == 0x0,
double space
> it's in not PXM but CPU selector value with pending event
suggest dropping "in"
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> docs/specs/acpi_cpu_hotplug.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt
> index ee219c8358..ac5903b2b1 100644
> --- a/docs/specs/acpi_cpu_hotplug.txt
> +++ b/docs/specs/acpi_cpu_hotplug.txt
> @@ -44,9 +44,10 @@ read access:
> 3-7: reserved and should be ignored by OSPM
> [0x5-0x7] reserved
> [0x8] Command data: (DWORD access)
since we're fixing this dword field description, can you spell out the
endianness too?
(I think endianness is relevant here, because patch#2 suggests selectors
can be looped over. So selectors are actual integers, not just 32-bit
opaque blobs.)
> - in case of error or unsupported command reads is 0xFFFFFFFF
> + in case of error or unsupported command reads is 0x0
> current 'Command field' value:
> - 0: returns PXM value corresponding to device
> + 0: returns CPU selector value corresponding to a CPU with
> + pending event.
>
> write access:
> offset:
>
Thanks!
Laszlo
[RFC 2/3] acpi: cpuhp: add typical usecases into spec, Igor Mammedov, 2019/10/09