[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 2 PATCH 04/16] machine: Add SMP Sockets in CpuTopo
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [RFC 2 PATCH 04/16] machine: Add SMP Sockets in CpuTopology |
Date: |
Thu, 10 Oct 2019 23:31:12 -0300 |
On Fri, Sep 06, 2019 at 07:12:04PM +0000, Moger, Babu wrote:
> Store the smp Sockets in CpuTopology. Socket information
> is required to build the cpu topology in new epyc mode.
>
> Signed-off-by: Babu Moger <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
> ---
> hw/core/machine.c | 1 +
> hw/i386/pc.c | 1 +
> include/hw/boards.h | 2 ++
> vl.c | 1 +
> 4 files changed, 5 insertions(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index c58a8e594e..4034b7e903 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -795,6 +795,7 @@ static void smp_parse(MachineState *ms, QemuOpts *opts)
> ms->smp.cpus = cpus;
> ms->smp.cores = cores;
> ms->smp.threads = threads;
> + ms->smp.sockets = sockets;
> }
>
> if (ms->smp.cpus > 1) {
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 95aab8e5e7..9e1c3f9f57 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1609,6 +1609,7 @@ void pc_smp_parse(MachineState *ms, QemuOpts *opts)
> ms->smp.cpus = cpus;
> ms->smp.cores = cores;
> ms->smp.threads = threads;
> + ms->smp.sockets = sockets;
> pcms->smp_dies = dies;
> }
>
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index a71d1a53a5..12eb5032a5 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -245,12 +245,14 @@ typedef struct DeviceMemoryState {
> * @cpus: the number of present logical processors on the machine
> * @cores: the number of cores in one package
> * @threads: the number of threads in one core
> + * @sockets: the number of sockets on the machine
> * @max_cpus: the maximum number of logical processors on the machine
> */
> typedef struct CpuTopology {
> unsigned int cpus;
> unsigned int cores;
> unsigned int threads;
> + unsigned int sockets;
> unsigned int max_cpus;
> } CpuTopology;
>
> diff --git a/vl.c b/vl.c
> index 711d2ae5da..473a688779 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3981,6 +3981,7 @@ int main(int argc, char **argv, char **envp)
> current_machine->smp.max_cpus = machine_class->default_cpus;
> current_machine->smp.cores = 1;
> current_machine->smp.threads = 1;
> + current_machine->smp.sockets = 1;
>
> machine_class->smp_parse(current_machine,
> qemu_opts_find(qemu_find_opts("smp-opts"), NULL));
>
--
Eduardo
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [RFC 2 PATCH 04/16] machine: Add SMP Sockets in CpuTopology,
Eduardo Habkost <=