[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: fix counting typo error
From: |
Markus Armbruster |
Subject: |
Re: [PATCH] tests: fix counting typo error |
Date: |
Fri, 11 Oct 2019 13:13:37 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Tianjia Zhang <address@hidden> writes:
> Instead of global variables, local variables should be incrementing,
> This is a typo fix.
Impact?
The commit message calls it a "typo", which suggests there is none. The
patch makes me suspect the bug is more serious than that.
>
> Signed-off-by: Tianjia Zhang <address@hidden>
> ---
> tests/test-rcu-list.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/test-rcu-list.c b/tests/test-rcu-list.c
> index 6f076473e0..c0fc47ded4 100644
> --- a/tests/test-rcu-list.c
> +++ b/tests/test-rcu-list.c
> @@ -219,7 +219,7 @@ static void *rcu_q_updater(void *arg)
> j++;
> if (target_el == j) {
> struct list_element *new_el = g_new(struct list_element, 1);
> - n_nodes += n_nodes_local;
> + n_nodes_local++;
> TEST_LIST_INSERT_AFTER_RCU(el, new_el, entry);
> break;
> }