qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v5 007/126] nbd: well form nbd_iter_channel_error errp handler


From: Eric Blake
Subject: Re: [RFC v5 007/126] nbd: well form nbd_iter_channel_error errp handler
Date: Fri, 11 Oct 2019 11:48:50 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0

On 10/11/19 11:03 AM, Vladimir Sementsov-Ogievskiy wrote:
Make nbd_iter_channel_error errp handler well formed:
rename errp to errp_in, as it is IN-parameter here (which is unusual

Actually, rename local_err to errp_in.

for errp).

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
  block/nbd.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)


With commit message fixed,

Reviewed-by: Eric Blake <address@hidden>

  static void nbd_iter_channel_error(NBDReplyChunkIter *iter,
-                                   int ret, Error **local_err)
+                                   int ret, Error **errp_in)

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]