[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/21] migration/postcopy: mis->have_listen_thread check will neve
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 13/21] migration/postcopy: mis->have_listen_thread check will never be touched |
Date: |
Fri, 11 Oct 2019 20:16:38 +0100 |
From: Wei Yang <address@hidden>
If mis->have_listen_thread is true, this means current PostcopyState
must be LISTENING or RUNNING. While the check at the beginning of the
function makes sure the state transaction happens when its previous
PostcopyState is ADVISE or DISCARD.
This means we would never touch this check.
Signed-off-by: Wei Yang <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/savevm.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 241c5dd097..c62687afef 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1878,11 +1878,6 @@ static int
loadvm_postcopy_handle_listen(MigrationIncomingState *mis)
return -1;
}
- if (mis->have_listen_thread) {
- error_report("CMD_POSTCOPY_RAM_LISTEN already has a listen thread");
- return -1;
- }
-
mis->have_listen_thread = true;
/* Start up the listening thread and wait for it to signal ready */
qemu_sem_init(&mis->listen_thread_sem, 0);
--
2.23.0
- [PULL 03/21] migration: Fix missing rcu_read_unlock, (continued)
- [PULL 03/21] migration: Fix missing rcu_read_unlock, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 05/21] migration: Use automatic rcu_read unlock in rdma.c, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 08/21] migration/postcopy: allocate tmp_page in setup stage, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 04/21] migration: Use automatic rcu_read unlock in ram.c, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 06/21] rcu: Use automatic rc_read unlock in core memory/exec code, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 09/21] migration/postcopy: map large zero page in postcopy_ram_incoming_setup(), Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 07/21] migration: Don't try and recover return path in non-postcopy, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 11/21] migration: pass in_postcopy instead of check state again, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 10/21] migration/postcopy: fix typo in mark_postcopy_blocktime_begin's comment, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 12/21] migration: report SaveStateEntry id and name on failure, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 13/21] migration/postcopy: mis->have_listen_thread check will never be touched,
Dr. David Alan Gilbert (git) <=
- [PULL 14/21] migration/postcopy: postpone setting PostcopyState to END, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 15/21] migration/postcopy: rename postcopy_ram_enable_notify to postcopy_ram_incoming_setup, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 16/21] migration/postcopy: check PostcopyState before setting to POSTCOPY_INCOMING_RUNNING, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 17/21] migration/multifd: fix a typo in comment of multifd_recv_unfill_packet(), Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 18/21] migration/multifd: use pages->allocated instead of the static max, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 19/21] migration/multifd: initialize packet->magic/version once at setup stage, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 20/21] migration/multifd: pages->used would be cleared when attach to multifd_send_state, Dr. David Alan Gilbert (git), 2019/10/11
- [PULL 21/21] migration: Support gtree migration, Dr. David Alan Gilbert (git), 2019/10/11
- Re: [PULL 00/21] migration queue, Peter Maydell, 2019/10/14