|
From: | Eric Blake |
Subject: | Re: [PATCH 3/4] qemu-img: Support help options for --object |
Date: | Fri, 11 Oct 2019 16:37:56 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
On 10/11/19 3:55 PM, Kevin Wolf wrote:
Missing man page documentation of this new feature. Perhaps iotest coverage is also warranted? (qemu-io is only for testing purposes, so I don't care about that in patch 2 as much as I do here)Instead of parsing help options as normal object properties and returning an error, provide the same help functionality as the system emulator in qemu-img, too. Signed-off-by: Kevin Wolf <address@hidden> --- qemu-img.c | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-)
But the patch itself is a strict improvement, so Reviewed-by: Eric Blake <address@hidden> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |