qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v5 020/126] include/qom/object.h: rename Error ** parameter to


From: Philippe Mathieu-Daudé
Subject: Re: [RFC v5 020/126] include/qom/object.h: rename Error ** parameter to more common errp
Date: Sat, 12 Oct 2019 08:07:25 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0

On 10/11/19 6:04 PM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
  include/qom/object.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/qom/object.h b/include/qom/object.h
index 128d00c77f..716f6f655d 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -1635,9 +1635,9 @@ void object_class_property_add_uint32_ptr(ObjectClass 
*klass, const char *name,
   * property of type 'uint64'.
   */
  void object_property_add_uint64_ptr(Object *obj, const char *name,
-                                    const uint64_t *v, Error **Errp);
+                                    const uint64_t *v, Error **errp);
  void object_class_property_add_uint64_ptr(ObjectClass *klass, const char 
*name,
-                                          const uint64_t *v, Error **Errp);
+                                          const uint64_t *v, Error **errp);

Oddly the implementation already use lowercase.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

/**
   * object_property_add_alias:




reply via email to

[Prev in Thread] Current Thread [Next in Thread]