Re: [PATCH v4 0/8] target/mips: Misc cleanups for September/October 2019

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v4 0/8] target/mips: Misc cleanups for September/October 2019
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
76d4761 target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>
7b0a0b7 target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>
1ee0158 target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>
8c4be75 target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>
09d48e2 target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>
a001bf2 MAINTAINERS: Update mail address of Aleksandar Rikalo
15ef1cc target/mips: Clean up op_helper.c
28b6fc5 target/mips: Clean up helper.c

=== OUTPUT BEGIN ===
1/8 Checking commit 28b6fc5e98d0 (target/mips: Clean up helper.c)
2/8 Checking commit 15ef1ccfe587 (target/mips: Clean up op_helper.c)
ERROR: spaces required around that '*' (ctx:WxV)
#1058: FILE: target/mips/op_helper.c:3871:
+                                  float_status *status)              \
                                                ^

total: 1 errors, 0 warnings, 1681 lines checked

Patch 2/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/8 Checking commit a001bf23ddfb (MAINTAINERS: Update mail address of 
Aleksandar Rikalo)
4/8 Checking commit 09d48e2771b1 (target/mips: msa: Split helpers for 
<MAX|MIN>_A.<B|H|W|D>)
5/8 Checking commit 8c4be7515269 (target/mips: msa: Split helpers for 
<MAX|MIN>_<S|U>.<B|H|W|D>)
6/8 Checking commit 1ee0158f8980 (target/mips: msa: Split helpers for 
ILV<EV|OD|L|R>.<B|H|W|D>)
7/8 Checking commit 7b0a0b7b2d3b (target/mips: msa: Split helpers for 
ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>)
8/8 Checking commit 76d47617ff60 (target/mips: msa: Split helpers for 
HADD_<S|U>.<H|W|D>)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden