Re: [PATCH v5 23/55] translator: add translator_ld{ub,sw,uw,l,q}

[Richard Henderson]

On 10/14/19 3:49 AM, Alex Bennée wrote:
> From: "Emilio G. Cota" <address@hidden>
> 
> We don't bother with replicating the fast path (tlb_hit) of the old
> cpu_ldst helpers as it has no measurable effect on performance. This
> probably indicates we should consider flattening the whole set of
> helpers but that is out of scope for this change.
> 
> Suggested-by: Richard Henderson <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> [AJB: directly plumb into softmmu/user helpers]
> Signed-off-by: Alex Bennée <address@hidden>
> 
> ---
> v4
>   - don't use the cpu_ldst helpers, plumb directly into the lower
>   level
>   - mark the CODE_ACCESS/SOFTMMU_CODE_ACCESS as deprecated
> v5
>   - expand commit message w.r.t. fast path.
> ---

Reviewed-by: Richard Henderson <address@hidden>


r~