Re: [PATCH for 4.2 v5 00/55] Support for TCG plugins

qemu-devel
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for 4.2 v5 00/55] Support for TCG plugins

From:	no-reply
Subject:	Re: [PATCH for 4.2 v5 00/55] Support for TCG plugins
Date:	Mon, 14 Oct 2019 21:36:31 -0700 (PDT)
Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH for 4.2 v5 00/55] Support for TCG plugins
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
3c4538d .travis.yml: add --enable-plugins tests
52d40be plugins: add qemu_plugin_outs and use it
173764d plugins: add sparc64 instruction classification table
984bf57 plugins: make howvec plugin more generic
8d5b793 plugins: expand the plugin_init function to include an info block
d9fde51 include/exec: wrap cpu_ldst.h in CONFIG_TCG
c968fc4 accel/stubs: reduce headers from tcg-stub
277050d tests/plugin: add hotpages plugin to breakdown memory access patterns
09bc325 tests/plugin: add instruction execution breakdown
3504de4 plugin: add qemu_plugin_insn_disas helper
28695ed tests/plugin: add a hotblocks plugin
2c35bc8 tests/tcg: enable plugin testing
4e61a46 tests/tcg: drop test-i386-fprem from TESTS when not SLOW
e7cbabb tests/tcg: move "virtual" tests to EXTRA_TESTS
71e2c9a tests/tcg: set QEMU_OPTS for all cris runs
19cc0a9 tests/tcg/Makefile.target: fix path to config-host.mak
32a7520 tests/plugin: add sample plugins
fdc50ab linux-user: support -plugin option
4502888 vl: support -plugin option
557ab9f plugin: add API symbols to qemu-plugins.symbols
452fc4f translator: inject instrumentation from plugins
ef58223 target/openrisc: fetch code with translator_ld
322a6e2 target/xtensa: fetch code with translator_ld
7746583 target/sparc: fetch code with translator_ld
20a99e5 target/riscv: fetch code with translator_ld
e456086 target/alpha: fetch code with translator_ld
dc5cd57 target/m68k: fetch code with translator_ld
3c933f4 target/hppa: fetch code with translator_ld
788ef4b target/i386: fetch code with translator_ld
756d7ac target/sh4: fetch code with translator_ld
96a68ab target/ppc: fetch code with translator_ld
8579c0a target/arm: fetch code with translator_ld
58d5ac3 translator: add translator_ld{ub,sw,uw,l,q}
9447806 plugin-gen: add plugin_insn_append
6c45871 cpu: hook plugin vcpu events
f35ce99 *-user: plugin syscalls
b464131 *-user: notify plugin of exit
5f45de7 translate-all: notify plugin code of tb_flush
90bebf1 plugins: implement helpers for resolving hwaddr
fd4c2fe tcg: let plugins instrument virtual memory accesses
b8e5c38 atomic_template: add inline trace/plugin helpers
cc9eeaa plugin-gen: add module for TCG-related code
6d95ee8 tcg: add tcg_gen_st_ptr
d0544ab cputlb: introduce get_page_addr_code_hostp
e337afd cputlb: document get_page_addr_code
d181e35 queue: add QTAILQ_REMOVE_SEVERAL
b5a5805 plugin: add implementation of the api
38dbddf plugin: add core code
dc6c029 plugin: add user-facing API
ce651ea configure: add --enable-plugins (MOVE TO END)
87ba90a docs/devel: add plugins.rst design document
a180702 translate-all: use cpu_in_exclusive_work_context() in tb_flush
de0849f cpu: introduce cpu_in_exclusive_context()
d8f88ce trace: add mmu_index to mem_info
03da1d4 trace: expand mem_info:size_shift to 4 bits

=== OUTPUT BEGIN ===
1/55 Checking commit 03da1d48f815 (trace: expand mem_info:size_shift to 4 bits)
2/55 Checking commit d8f88ceb4132 (trace: add mmu_index to mem_info)
ERROR: line over 90 characters
#25: FILE: accel/tcg/atomic_template.h:63:
+        uint16_t info = glue(trace_mem_build_info_no_se, MEND)(SHIFT, false, 
ATOMIC_MMU_IDX); \

ERROR: line over 90 characters
#34: FILE: accel/tcg/atomic_template.h:71:
+        uint16_t info = glue(trace_mem_build_info_no_se, MEND)(SHIFT, false, 
ATOMIC_MMU_IDX); \

ERROR: line over 90 characters
#41: FILE: accel/tcg/atomic_template.h:77:
+        uint16_t info = glue(trace_mem_build_info_no_se, MEND)(SHIFT, true, 
ATOMIC_MMU_IDX); \

total: 3 errors, 0 warnings, 261 lines checked

Patch 2/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/55 Checking commit de0849f5305b (cpu: introduce cpu_in_exclusive_context())
4/55 Checking commit a180702bc2c7 (translate-all: use 
cpu_in_exclusive_work_context() in tb_flush)
5/55 Checking commit 87ba90add578 (docs/devel: add plugins.rst design document)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24: 
new file mode 100644

total: 0 errors, 1 warnings, 116 lines checked

Patch 5/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/55 Checking commit ce651eab7b66 (configure: add --enable-plugins (MOVE TO 
END))
7/55 Checking commit dc6c0292a53b (plugin: add user-facing API)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

WARNING: architecture specific defines should be avoided
#41: FILE: include/qemu/qemu-plugin.h:22:
+#if defined _WIN32 || defined __CYGWIN__

WARNING: architecture specific defines should be avoided
#49: FILE: include/qemu/qemu-plugin.h:30:
+  #if __GNUC__ >= 4

total: 0 errors, 3 warnings, 351 lines checked

Patch 7/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/55 Checking commit 38dbddf37d35 (plugin: add core code)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#85: 
new file mode 100644

ERROR: "foo * bar" should be "foo *bar"
#221: FILE: include/qemu/plugin.h:132:
+static inline struct qemu_plugin_insn * qemu_plugin_insn_alloc(void)

ERROR: named QLIST_HEAD should be typedefed separately
#404: FILE: plugins/core.c:42:
+QLIST_HEAD(qemu_plugin_cb_head, qemu_plugin_cb);

WARNING: line over 80 characters
#623: FILE: plugins/core.c:261:
+        cbs = g_array_sized_new(false, false, sizeof(struct 
qemu_plugin_dyn_cb), 1);

WARNING: Block comments use a leading /* on a separate line
#931: FILE: plugins/loader.c:59:
+        { /* end of list */ }

ERROR: externs should be avoided in .c files
#937: FILE: plugins/loader.c:65:
+extern struct qemu_plugin_state plugin;

total: 3 errors, 3 warnings, 1283 lines checked

Patch 8/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/55 Checking commit b5a580553858 (plugin: add implementation of the api)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

ERROR: "foo * bar" should be "foo *bar"
#291: FILE: plugins/api.c:265:
+static MachineState * get_ms(void)

total: 1 errors, 1 warnings, 291 lines checked

Patch 9/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/55 Checking commit d181e35fd957 (queue: add QTAILQ_REMOVE_SEVERAL)
WARNING: Block comments use a leading /* on a separate line
#32: FILE: include/qemu/queue.h:431:
+    } while (/*CONSTCOND*/0)

total: 0 errors, 1 warnings, 16 lines checked

Patch 10/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/55 Checking commit e337afd4f7ba (cputlb: document get_page_addr_code)
12/55 Checking commit d0544ab75fda (cputlb: introduce get_page_addr_code_hostp)
13/55 Checking commit 6d95ee8cb30d (tcg: add tcg_gen_st_ptr)
14/55 Checking commit cc9eeaa0a629 (plugin-gen: add module for TCG-related code)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 1123 lines checked

Patch 14/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/55 Checking commit b8e5c38572ae (atomic_template: add inline trace/plugin 
helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 296 lines checked

Patch 15/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/55 Checking commit fd4c2fe3e305 (tcg: let plugins instrument virtual memory 
accesses)
WARNING: line over 80 characters
#111: FILE: include/exec/cpu_ldst_template.h:91:
+    uint16_t meminfo = trace_mem_build_info(SHIFT, false, MO_TE, false, 
mmu_idx);

total: 0 errors, 1 warnings, 322 lines checked

Patch 16/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/55 Checking commit 90bebf129835 (plugins: implement helpers for resolving 
hwaddr)
18/55 Checking commit 5f45de7bce60 (translate-all: notify plugin code of 
tb_flush)
19/55 Checking commit b464131a3109 (*-user: notify plugin of exit)
20/55 Checking commit f35ce994630e (*-user: plugin syscalls)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#93: 
new file mode 100644

total: 0 errors, 1 warnings, 127 lines checked

Patch 20/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/55 Checking commit 6c45871d214f (cpu: hook plugin vcpu events)
22/55 Checking commit 94478062431c (plugin-gen: add plugin_insn_append)
23/55 Checking commit 58d5ac329cb5 (translator: add translator_ld{ub,sw,uw,l,q})
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#81: FILE: include/exec/translator.h:161:
+#define DO_LOAD(type, name, shift)               \
+    set_helper_retaddr(1);                       \
+    ret = name ## _p(g2h(pc));                   \
+    clear_helper_retaddr();

WARNING: Block comments use a leading /* on a separate line
#114: FILE: include/exec/translator.h:194:
+GEN_TRANSLATOR_LD(translator_ldub, ldb, uint8_t, 0, /* no swap needed */)

total: 1 errors, 1 warnings, 116 lines checked

Patch 23/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

24/55 Checking commit 8579c0acf750 (target/arm: fetch code with translator_ld)
25/55 Checking commit 96a68abee927 (target/ppc: fetch code with translator_ld)
26/55 Checking commit 756d7ac99834 (target/sh4: fetch code with translator_ld)
27/55 Checking commit 788ef4b5927e (target/i386: fetch code with translator_ld)
28/55 Checking commit 3c933f4f3faa (target/hppa: fetch code with translator_ld)
29/55 Checking commit dc5cd57c35c4 (target/m68k: fetch code with translator_ld)
30/55 Checking commit e456086d0d91 (target/alpha: fetch code with translator_ld)
31/55 Checking commit 20a99e55c877 (target/riscv: fetch code with translator_ld)
32/55 Checking commit 77465835e70b (target/sparc: fetch code with translator_ld)
33/55 Checking commit 322a6e272620 (target/xtensa: fetch code with 
translator_ld)
34/55 Checking commit ef58223c94ef (target/openrisc: fetch code with 
translator_ld)
35/55 Checking commit 452fc4f67497 (translator: inject instrumentation from 
plugins)
36/55 Checking commit 557ab9fcb99e (plugin: add API symbols to 
qemu-plugins.symbols)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#136: 
new file mode 100644

total: 0 errors, 1 warnings, 166 lines checked

Patch 36/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
37/55 Checking commit 4502888fd6b3 (vl: support -plugin option)
38/55 Checking commit fdc50ab64b57 (linux-user: support -plugin option)
39/55 Checking commit 32a75208b318 (tests/plugin: add sample plugins)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

total: 0 errors, 1 warnings, 287 lines checked

Patch 39/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/55 Checking commit 19cc0a9df50d (tests/tcg/Makefile.target: fix path to 
config-host.mak)
41/55 Checking commit 71e2c9a8f84f (tests/tcg: set QEMU_OPTS for all cris runs)
42/55 Checking commit e7cbabbbdda6 (tests/tcg: move "virtual" tests to 
EXTRA_TESTS)
43/55 Checking commit 4e61a46a42ec (tests/tcg: drop test-i386-fprem from TESTS 
when not SLOW)
44/55 Checking commit 2c35bc84f958 (tests/tcg: enable plugin testing)
45/55 Checking commit 28695ed94613 (tests/plugin: add a hotblocks plugin)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

WARNING: line over 80 characters
#102: FILE: tests/plugin/hotblocks.c:65:
+            g_string_append_printf(report, "%#016"PRIx64", %d, %ld, 
%"PRId64"\n",

total: 0 errors, 2 warnings, 155 lines checked

Patch 45/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
46/55 Checking commit 3504de4e1f94 (plugin: add qemu_plugin_insn_disas helper)
ERROR: "foo * bar" should be "foo *bar"
#93: FILE: disas.c:539:
+char * plugin_disas(CPUState *cpu, uint64_t addr, size_t size)

ERROR: Error messages should not contain newlines
#136: FILE: disas.c:582:
+        warn_report("%s: %zu bytes left over\n", __func__, size - count);

ERROR: "foo * bar" should be "foo *bar"
#153: FILE: include/disas/disas.h:17:
+char * plugin_disas(CPUState *cpu, uint64_t addr, size_t size);

ERROR: "foo * bar" should be "foo *bar"
#172: FILE: include/qemu/qemu-plugin.h:334:
+char * qemu_plugin_insn_disas(const struct qemu_plugin_insn *insn);

total: 4 errors, 0 warnings, 171 lines checked

Patch 46/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

47/55 Checking commit 09bc325b2af1 (tests/plugin: add instruction execution 
breakdown)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

ERROR: space required after that ',' (ctx:VxV)
#102: FILE: tests/plugin/howvec.c:71:
+    { "  Add/Sub (imm,tags)","asit",   0x1f800000, 0x11800000, COUNT_CLASS},
                             ^

ERROR: space required after that ',' (ctx:VxV)
#125: FILE: tests/plugin/howvec.c:94:
+    { "  AdvSimd ldstmult++","advlsmp",0xbfb00000, 0x0c800000, COUNT_CLASS},
                             ^

ERROR: space required after that ',' (ctx:VxV)
#125: FILE: tests/plugin/howvec.c:94:
+    { "  AdvSimd ldstmult++","advlsmp",0xbfb00000, 0x0c800000, COUNT_CLASS},
                                       ^

ERROR: space required after that ',' (ctx:VxV)
#127: FILE: tests/plugin/howvec.c:96:
+    { "  AdvSimd ldst++",    "advlssp",0xbf800000, 0x0d800000, COUNT_CLASS},
                                       ^

ERROR: space required after that ',' (ctx:VxV)
#131: FILE: tests/plugin/howvec.c:100:
+    { "  ldst noalloc pair", "ldstnap",0x3b800000, 0x28000000, COUNT_CLASS},
                                       ^

ERROR: space required after that ',' (ctx:VxV)
#135: FILE: tests/plugin/howvec.c:104:
+    { "  ldst reg (reg off)","ldstro", 0x3b200b00, 0x38200800, COUNT_CLASS},
                             ^

WARNING: line over 80 characters
#170: FILE: tests/plugin/howvec.c:139:
+            g_string_append_printf(report, "Class: %-24s\tcounted 
individually\n",

ERROR: space required after that ',' (ctx:VxV)
#186: FILE: tests/plugin/howvec.c:155:
+        g_string_append_printf(report,"Individual Instructions:\n");
                                      ^

WARNING: line over 80 characters
#192: FILE: tests/plugin/howvec.c:161:
+            g_string_append_printf(report, "Instr: %-24s\t(%ld 
hits)\t(op=%#08x/%s)\n",

ERROR: "foo * bar" should be "foo *bar"
#217: FILE: tests/plugin/howvec.c:186:
+static uint64_t * find_counter(struct qemu_plugin_insn *insn)

WARNING: line over 80 characters
#249: FILE: tests/plugin/howvec.c:218:
+                                                       
GUINT_TO_POINTER(opcode));

total: 8 errors, 4 warnings, 310 lines checked

Patch 47/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

48/55 Checking commit 277050daf1db (tests/plugin: add hotpages plugin to 
breakdown memory access patterns)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 186 lines checked

Patch 48/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
49/55 Checking commit c968fc46a5e0 (accel/stubs: reduce headers from tcg-stub)
50/55 Checking commit d9fde5180956 (include/exec: wrap cpu_ldst.h in CONFIG_TCG)
51/55 Checking commit 8d5b793b5566 (plugins: expand the plugin_init function to 
include an info block)
ERROR: line over 90 characters
#82: FILE: plugins/loader.c:66:
+typedef int (*qemu_plugin_install_func_t)(qemu_plugin_id_t, const qemu_info_t 
*, int, char **);

ERROR: "foo * bar" should be "foo *bar"
#112: FILE: plugins/loader.c:259:
+    MachineState * ms = MACHINE(qdev_get_machine());

total: 2 errors, 0 warnings, 176 lines checked

Patch 51/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

52/55 Checking commit 984bf57ce9d8 (plugins: make howvec plugin more generic)
WARNING: line over 80 characters
#49: FILE: tests/plugin/howvec.c:117:
+    { "Unclassified",        "unclas", 0x00000000, 0x00000000, 
COUNT_INDIVIDUAL},

ERROR: that open brace { should be on the previous line
#59: FILE: tests/plugin/howvec.c:127:
+ClassSelector class_tables[] =
+{

total: 1 errors, 1 warnings, 132 lines checked

Patch 52/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

53/55 Checking commit 173764dcb67b (plugins: add sparc64 instruction 
classification table)
WARNING: line over 80 characters
#29: FILE: tests/plugin/howvec.c:124:
+    { "Unclassified",        "unclas", 0x00000000, 0x00000000, 
COUNT_INDIVIDUAL},

WARNING: line over 80 characters
#38: FILE: tests/plugin/howvec.c:133:
+    { "Unclassified",        "unclas", 0x00000000, 0x00000000, 
COUNT_INDIVIDUAL},

total: 0 errors, 2 warnings, 34 lines checked

Patch 53/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
54/55 Checking commit 52d40be360ad (plugins: add qemu_plugin_outs and use it)
WARNING: line over 80 characters
#170: FILE: tests/plugin/hotpages.c:71:
+    g_autoptr(GString) report = g_string_new("Addr, RCPUs, Reads, WCPUs, 
Writes\n");

total: 0 errors, 1 warnings, 278 lines checked

Patch 54/55 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
55/55 Checking commit 3c4538dc4aa7 (.travis.yml: add --enable-plugins tests)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
[Prev in Thread]
Current Thread
[Next in Thread]
[PATCH v5 47/55] tests/plugin: add instruction execution breakdown, (continued)
- [PATCH v5 47/55] tests/plugin: add instruction execution breakdown, Alex Bennée, 2019/10/14
  - Re: [PATCH v5 47/55] tests/plugin: add instruction execution breakdown, Richard Henderson, 2019/10/14
- [PATCH v5 36/55] plugin: add API symbols to qemu-plugins.symbols, Alex Bennée, 2019/10/14
  - Re: [PATCH v5 36/55] plugin: add API symbols to qemu-plugins.symbols, Richard Henderson, 2019/10/14
- [PATCH v5 41/55] tests/tcg: set QEMU_OPTS for all cris runs, Alex Bennée, 2019/10/14
  - Re: [PATCH v5 41/55] tests/tcg: set QEMU_OPTS for all cris runs, Richard Henderson, 2019/10/14
- [PATCH v5 39/55] tests/plugin: add sample plugins, Alex Bennée, 2019/10/14
  - Re: [PATCH v5 39/55] tests/plugin: add sample plugins, Richard Henderson, 2019/10/14
- [PATCH v5 44/55] tests/tcg: enable plugin testing, Alex Bennée, 2019/10/14
  - Re: [PATCH v5 44/55] tests/tcg: enable plugin testing, Richard Henderson, 2019/10/14
- Re: [PATCH for 4.2 v5 00/55] Support for TCG plugins, no-reply <=
Prev by Date: Re: [PATCH v1 3/5] contrib/gitdm: add Andrey to the individual group
Next by Date: Re: [PATCH v12 09/11] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)
Previous by thread: Re: [PATCH v5 44/55] tests/tcg: enable plugin testing
Next by thread: [PATCH] tests: fix iothread_join() race condition
Index(es):
- Date
- Thread