[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 1/2] trace: add --group=all to tracing.txt
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PULL 1/2] trace: add --group=all to tracing.txt |
|
Date: |
Tue, 15 Oct 2019 09:45:50 +0100 |
|
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Mon, Oct 14, 2019 at 11:08:25AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Stefan,
>
> On 10/14/19 10:57 AM, Stefan Hajnoczi wrote:
> > tracetool needs to know the group name ("all", "root", or a specific
> > subdirectory). Also remove the stdin redirection because tracetool.py
> > needs the path to the trace-events file. Update the documentation.
> >
> > Fixes: 2098c56a9bc5901e145fa5d4759f075808811685
> > ("trace: move setting of group name into Makefiles")
> > Launchpad: https://bugs.launchpad.net/bugs/1844814
>
> Sorry I didn't noticed that earlier, but on
> https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message
> we recommend using the 'Buglink' tag.
> Not sure it's worth resending another pull request...
Sure, it hasn't been merged yet so I can send a v2.
Stefan
signature.asc
Description: PGP signature