Re: [PATCH v2 00/21] iotests: Allow ./check -o data_file

[Max Reitz]

On 16.10.19 02:19, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Subject: [PATCH v2 00/21] iotests: Allow ./check -o data_file
> Type: series
> Message-id: address@hidden
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> Switched to a new branch 'test'
> 7e75916 iotests: Allow check -o data_file
> a21918d iotests: Disable data_file where it cannot be used
> 1eb7209 iotests: Make 198 work with data_file
> 02453ff iotests: Make 137 work with data_file
> cdb651c iotests: Make 110 work with data_file
> 1b30e90 iotests: Make 091 work with data_file
> 26ebffa iotests: Avoid cp/mv of test images
> 5d6ba79 iotests: Use _rm_test_img for deleting test images
> 4c20fa0 iotests: Avoid qemu-img create
> 944555b iotests: Drop IMGOPTS use in 267
> 9037b83 iotests: Replace IMGOPTS='' by --no-opts
> e62282b iotests: Replace IMGOPTS= by -o
> 26d39b5 iotests: Inject space into -ocompat=0.10 in 051
> 99d129e iotests: Add -o and --no-opts to _make_test_img
> 301f2c3 iotests: Let _make_test_img parse its parameters
> 53a8dea iotests: Drop compat=1.1 in 050
> 85b18f8 iotests: Replace IMGOPTS by _unsupported_imgopts
> 476fb23 iotests: Filter refcount_order in 036
> 67b9119 iotests: Add _filter_json_filename
> fbf9402 iotests/qcow2.py: Split feature fields into bits
> afe3486 iotests/qcow2.py: Add dump-header-exts
> 
> === OUTPUT BEGIN ===
> 1/21 Checking commit afe348661672 (iotests/qcow2.py: Add dump-header-exts)
> ERROR: line over 90 characters
> #32: FILE: tests/qemu-iotests/qcow2.py:237:
> +    [ 'dump-header-exts',     cmd_dump_header_exts,     0, 'Dump image 
> header extensions' ],
> 
> total: 1 errors, 0 warnings, 17 lines checked

I actually saw this error locally but decided to go with it because it
fits the current style of qcow2.py in that place.  (And I don’t think
the line length does any harm there.)

Max

signature.asc
Description: OpenPGP digital signature