Re: [PATCH v9 14/15] hw/i386: Introduce the microvm machine type

[Philippe Mathieu-Daudé]

On 10/16/19 9:46 AM, Paolo Bonzini wrote:
> > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> > index c5c9d4900e..d399dcba52 100644
> > --- a/hw/i386/Kconfig
> > +++ b/hw/i386/Kconfig
> > @@ -92,6 +92,10 @@ config Q35
> >       select SMBIOS
> >       select FW_CFG_DMA
> >   
> > +config MICROVM
> > +    bool
>
> Missing:
>
>      select ISA_BUS
>      select APIC
>      select IOAPIC
>      select I8259
>      select MC146818RTC

maybe 'select SERIAL_ISA' too?

> No need to post v10 just for this.
>
> Paolo
>
>
> > +    select VIRTIO_MMIO
> > +
> >   config VTD
> >       bool
> >   
> > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> > index 7ed80a4853..0d195b5210 100644
> > --- a/hw/i386/Makefile.objs
> > +++ b/hw/i386/Makefile.objs
> > @@ -4,6 +4,7 @@ obj-y += x86.o
> >   obj-y += pc.o
> >   obj-$(CONFIG_I440FX) += pc_piix.o
> >   obj-$(CONFIG_Q35) += pc_q35.o
> > +obj-$(CONFIG_MICROVM) += microvm.o
> >   obj-y += fw_cfg.o pc_sysfw.o
> >   obj-y += x86-iommu.o
> >   obj-$(CONFIG_VTD) += intel_iommu.o