[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/4] migration: Check in savevm_state_handler_insert for d
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v2 4/4] migration: Check in savevm_state_handler_insert for dups |
|
Date: |
Wed, 16 Oct 2019 12:08:03 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Peter Xu <address@hidden> wrote:
> Before finally register one SaveStateEntry, we detect for duplicated
> entries. This could be helpful to notify us asap instead of get
> silent migration failures which could be hard to diagnose.
>
> For example, this patch will generate a message like this (if without
> previous fixes on x2apic) as long as we wants to boot a VM instance
> with "-smp 200,maxcpus=288,sockets=2,cores=72,threads=2" and QEMU will
> bail out even before VM starts:
>
> savevm_state_handler_insert: Detected duplicate SaveStateEntry: id=apic,
> instance_id=0x0
>
> Suggested-by: Dr. David Alan Gilbert <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
- [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus, Peter Xu, 2019/10/15
- [PATCH v2 1/4] migration: Define VMSTATE_INSTANCE_ID_ANY, Peter Xu, 2019/10/15
- [PATCH v2 2/4] migration: Change SaveStateEntry.instance_id into uint32_t, Peter Xu, 2019/10/15
- [PATCH v2 3/4] apic: Use 32bit APIC ID for migration instance ID, Peter Xu, 2019/10/15
- [PATCH v2 4/4] migration: Check in savevm_state_handler_insert for dups, Peter Xu, 2019/10/15
- Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus, Eduardo Habkost, 2019/10/16
- Re: [PATCH v2 0/4] apic: Fix migration breakage of >255 vcpus, Peter Xu, 2019/10/23