[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] checkpatch: sugguest to use qemu_real_host_page_size instead
|
From: |
Wei Yang |
|
Subject: |
Re: [PATCH] checkpatch: sugguest to use qemu_real_host_page_size instead of getpagesize() or sysconf(_SC_PAGESIZE) |
|
Date: |
Thu, 17 Oct 2019 08:42:33 +0800 |
|
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Wed, Oct 16, 2019 at 08:43:32AM -0700, Richard Henderson wrote:
>On 10/15/19 6:24 PM, Wei Yang wrote:
>> if ($line =~ /\bbzero\(/) {
>> ERROR("use memset() instead of bzero()\n" . $herecurr);
>> }
>> + if ($line =~ /getpagesize\(\)/) {
>> + ERROR("use qemu_real_host_page_size instead of
>> getpagesize()\n" . $herecurr);
>> + }
>> + if ($line =~ /sysconf\(_SC_PAGESIZE\)/) {
>
>Use \b to match beginning of symbol like bzero did?
>
You are right, thanks for the suggestion.
>
>r~
--
Wei Yang
Help you, Help me