[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/7] libqos: make the virtio-pci BAR index configurable
From: |
Thomas Huth |
Subject: |
Re: [PATCH v2 6/7] libqos: make the virtio-pci BAR index configurable |
Date: |
Thu, 17 Oct 2019 16:27:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 11/10/2019 10.56, Stefan Hajnoczi wrote:
> The Legacy virtio-pci interface always uses BAR 0. VIRTIO 1.0 may need
> to use a different BAR index, so make it configurable.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> tests/libqos/virtio-pci.h | 2 ++
> tests/libqos/virtio-pci.c | 3 ++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/libqos/virtio-pci.h b/tests/libqos/virtio-pci.h
> index b620c30451..f2d53aa377 100644
> --- a/tests/libqos/virtio-pci.h
> +++ b/tests/libqos/virtio-pci.h
> @@ -25,6 +25,8 @@ typedef struct QVirtioPCIDevice {
> uint16_t config_msix_entry;
> uint64_t config_msix_addr;
> uint32_t config_msix_data;
> +
> + uint8_t bar_idx;
I think I'd rather make that an "int" instead of "uint8_t" ... but
that's just my personal taste, so anyway:
Reviewed-by: Thomas Huth <address@hidden>
- [PATCH v2 4/7] libqos: add MSI-X callbacks to QVirtioPCIDevice, (continued)
- [PATCH v2 7/7] libqos: add VIRTIO PCI 1.0 support, Stefan Hajnoczi, 2019/10/11
- Re: [PATCH v2 7/7] libqos: add VIRTIO PCI 1.0 support, Sergio Lopez, 2019/10/11
- Re: [PATCH v2 7/7] libqos: add VIRTIO PCI 1.0 support, Thomas Huth, 2019/10/17
- Re: [PATCH v2 7/7] libqos: add VIRTIO PCI 1.0 support, Stefan Hajnoczi, 2019/10/17
- Re: [PATCH v2 7/7] libqos: add VIRTIO PCI 1.0 support, Thomas Huth, 2019/10/17
- Re: [PATCH v2 7/7] libqos: add VIRTIO PCI 1.0 support, Thomas Huth, 2019/10/18
- Re: [PATCH v2 7/7] libqos: add VIRTIO PCI 1.0 support, Thomas Huth, 2019/10/18
- Re: [PATCH v2 7/7] libqos: add VIRTIO PCI 1.0 support, Stefan Hajnoczi, 2019/10/18