[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/32] piix4: rename some variables in realize function
From: |
Thomas Huth |
Subject: |
Re: [PATCH 08/32] piix4: rename some variables in realize function |
Date: |
Thu, 17 Oct 2019 17:13:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 15/10/2019 18.26, Philippe Mathieu-Daudé wrote:
> From: Hervé Poussineau <address@hidden>
>
> PIIX4 structure is now 's'
> PCI device is now 'pci_dev'
> DeviceState is now 'dev'
Why? Just for the sake of it?
> Acked-by: Michael S. Tsirkin <address@hidden>
> Acked-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Hervé Poussineau <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/isa/piix4.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
> index 3294056cd5..4202243e41 100644
> --- a/hw/isa/piix4.c
> +++ b/hw/isa/piix4.c
> @@ -88,16 +88,17 @@ static const VMStateDescription vmstate_piix4 = {
> }
> };
>
> -static void piix4_realize(PCIDevice *dev, Error **errp)
> +static void piix4_realize(PCIDevice *pci_dev, Error **errp)
> {
> - PIIX4State *d = PIIX4_PCI_DEVICE(dev);
> + DeviceState *dev = DEVICE(pci_dev);
> + PIIX4State *s = DO_UPCAST(PIIX4State, dev, pci_dev);
AFAIK we rather want to get rid of DO_UPCAST in the long run, so please
don't introduce new ones!
See:
https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg05244.html
Unless there is a real need for the rename, I'd suggest to rather drop
this patch.
Thomas
- [PATCH 04/32] mc146818rtc: Move RTC_ISA_IRQ definition, (continued)
- [PATCH 04/32] mc146818rtc: Move RTC_ISA_IRQ definition, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 05/32] mc146818rtc: Include "mc146818rtc_regs.h" directly in mc146818rtc.c, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 06/32] mc146818rtc: always register rtc to rtc list, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 07/32] MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 08/32] piix4: rename some variables in realize function, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 09/32] piix4: add Reset Control Register, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 10/32] piix4: add a i8259 interrupt controller as specified in datasheet, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 11/32] Revert "irq: introduce qemu_irq_proxy()", Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 12/32] piix4: rename PIIX4 object to piix4-isa, Philippe Mathieu-Daudé, 2019/10/15
- [PATCH 13/32] piix4: convert reset function to QOM, Philippe Mathieu-Daudé, 2019/10/15