Re: [PATCH v2 4/6] s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION

[Richard Henderson]

On 10/21/19 1:57 AM, David Hildenbrand wrote:
> Looks like my idea of what a "borrow" is was wrong. The PoP says:
> 
>  "If the resulting subtraction results in a carry out of bit zero, a value
>  of one is placed in the corresponding element of the first operand;
>  otherwise, a value of zero is placed in the corresponding element"
> 
> As clarified by Richard, all we have to do is invert the result.
> 
> Fixes: 1ee2d7ba72f6 ("s390x/tcg: Implement VECTOR SUBTRACT COMPUTE BORROW 
> INDICATION")
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  target/s390x/translate_vx.inc.c | 7 ++++---
>  target/s390x/vec_int_helper.c   | 2 +-
>  2 files changed, 5 insertions(+), 4 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~