[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] cputlb: ensure _cmmu helper functions follow the naming s
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2] cputlb: ensure _cmmu helper functions follow the naming standard |
|
Date: |
Mon, 21 Oct 2019 09:12:27 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 10/21/19 8:09 AM, Alex Bennée wrote:
> We document this in docs/devel/load-stores.rst so lets follow it. The
> 32 bit and 64 bit access functions have historically not included the
> sign so we leave those as is. We also introduce some signed helpers
> which are used for loading immediate values in the translator.
>
> Fixes: 282dffc8
> Signed-off-by: Alex Bennée <address@hidden>
>
> ---
> v2
> - add signed ldsb and ldsw
> ---
> accel/tcg/cputlb.c | 24 +++++++++++++++++++++---
> include/exec/cpu_ldst_template.h | 4 ++--
> target/cris/translate_v10.inc.c | 3 +--
> tcg/tcg.h | 20 ++++++++++++++------
> 4 files changed, 38 insertions(+), 13 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
Queued.
r~