qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] memory-device: simplify Makefile.objs conditions

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] memory-device: simplify Makefile.objs conditions
Date: Mon, 21 Oct 2019 19:27:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 
On 10/21/19 7:11 PM, Paolo Bonzini wrote:

hw/mem/ is only included if CONFIG_MEM_DEVICE is true, so we need not
specify the condition again in hw/mem/Makefile.objs.


Yes, cleaner.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


Signed-off-by: Paolo Bonzini <address@hidden>
---
  hw/mem/Makefile.objs | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/mem/Makefile.objs b/hw/mem/Makefile.objs
index 3e2f7c5ca2..56345befd0 100644
--- a/hw/mem/Makefile.objs
+++ b/hw/mem/Makefile.objs
@@ -1,3 +1,3 @@
  common-obj-$(CONFIG_DIMM) += pc-dimm.o
-common-obj-$(CONFIG_MEM_DEVICE) += memory-device.o
+common-obj-y += memory-device.o
  common-obj-$(CONFIG_NVDIMM) += nvdimm.o
reply via email to
[Prev in Thread] Current Thread [Next in Thread]