[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/12] qapi: Allow introspecting fix for savevm's cooperation with
From: |
Markus Armbruster |
Subject: |
[PULL 12/12] qapi: Allow introspecting fix for savevm's cooperation with blockdev |
Date: |
Tue, 22 Oct 2019 09:56:15 +0200 |
From: Peter Krempa <address@hidden>
'savevm' was buggy as it considered all monitor-owned block device
nodes for snapshot. With the introduction of -blockdev, the common
usage made all nodes including protocol and backing file nodes be
monitor-owned and thus considered for snapshot.
This is a problem since the 'file' protocol nodes can't have internal
snapshots and it does not make sense to take snapshot of nodes
representing backing files.
This was fixed by commit 05f4aced658a02b02. Clients need to be able to
detect whether this fix is present.
Since savevm does not have an QMP alternative, add the feature for the
'human-monitor-command' backdoor which is used to call this command in
modern use.
Signed-off-by: Peter Krempa <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
---
qapi/misc.json | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/qapi/misc.json b/qapi/misc.json
index 6bd11f50e6..33b94e3589 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -1020,6 +1020,12 @@
#
# @cpu-index: The CPU to use for commands that require an implicit CPU
#
+# Features:
+# @savevm-monitor-nodes: If present, HMP command savevm only snapshots
+# monitor-owned nodes if they have no parents.
+# This allows the use of 'savevm' with
+# -blockdev. (since 4.2)
+#
# Returns: the output of the command as a string
#
# Since: 0.14.0
@@ -1047,7 +1053,8 @@
##
{ 'command': 'human-monitor-command',
'data': {'command-line': 'str', '*cpu-index': 'int'},
- 'returns': 'str' }
+ 'returns': 'str',
+ 'features': [ 'savevm-monitor-nodes' ] }
##
# @change:
--
2.21.0
- [PULL 00/12] QAPI patches for 2019-10-22, Markus Armbruster, 2019/10/22
- [PULL 03/12] qapi: Eliminate accidental global frontend state, Markus Armbruster, 2019/10/22
- [PULL 05/12] qapi: Move gen_enum(), gen_enum_lookup() back to qapi/types.py, Markus Armbruster, 2019/10/22
- [PULL 01/12] qapi: Don't suppress doc generation without pragma doc-required, Markus Armbruster, 2019/10/22
- [PULL 02/12] qapi: Store pragma state in QAPISourceInfo, not global state, Markus Armbruster, 2019/10/22
- [PULL 12/12] qapi: Allow introspecting fix for savevm's cooperation with blockdev,
Markus Armbruster <=
- [PULL 10/12] tests: qapi: Test 'features' of commands, Markus Armbruster, 2019/10/22
- [PULL 08/12] tests/qapi-schema: Tidy up test output indentation, Markus Armbruster, 2019/10/22
- [PULL 07/12] qapi: Clear scripts/qapi/doc.py executable bits again, Markus Armbruster, 2019/10/22
- [PULL 09/12] qapi: Add feature flags to commands, Markus Armbruster, 2019/10/22
- [PULL 11/12] tests/qapi-schema: Cover feature documentation comments, Markus Armbruster, 2019/10/22
- [PULL 04/12] qapi: Speed up frontend tests, Markus Armbruster, 2019/10/22
- [PULL 06/12] qapi: Split up scripts/qapi/common.py, Markus Armbruster, 2019/10/22
- Re: [PULL 00/12] QAPI patches for 2019-10-22, Peter Maydell, 2019/10/22